vim-latex-devel

[Vim-latex-devel] Bug with mapleader = " "

[Mika F. <mik...@zo...>]

Hi,

there's a bug with vim-latex, when setting g:mapleader to <space>. The
compile and view commands etc. get bound to "ll", "lv", and so on
instead of "<space>ll", "<space>lv", and so on. Needless to say this
messes things up quite a bit. The attached patch fixes this problem.

Please consider applying it.

Best regards,
 Mika

Re: [Vim-latex-devel] Bug with mapleader = " "

[Till M. <ope...@ti...>]

On Thu, Oct 07, 2010 at 09:26:23PM +0200, Mika Fischer wrote:
> Hi,
> 
> there's a bug with vim-latex, when setting g:mapleader to <space>. The
> compile and view commands etc. get bound to "ll", "lv", and so on
> instead of "<space>ll", "<space>lv", and so on. Needless to say this
> messes things up quite a bit. The attached patch fixes this problem.
> 
> Please consider applying it.

I applied it in changeset 1109. There are more occurences of mapleader,
e.g. in wizardfuncs.vim and texmenuconf.vim, don't they need to be
patched?

Regards
Till

Re: [Vim-latex-devel] Bug with mapleader = " "

[Mika F. <mik...@zo...>]

On Thu, Oct 7, 2010 at 22:21, Till Maas <ope...@ti...> wrote:
> I applied it in changeset 1109.

Great, thanks!

> There are more occurences of mapleader,
> e.g. in wizardfuncs.vim and texmenuconf.vim, don't they need to be
> patched?

No, because if I saw correctly, they're not used for mappings but for
displaying the mappings in the gvim menu and the wizard.

I guess it's not really helpful in this case, since the <space> will
probably not be visible anyway. Maybe space could be replaced by
<space> in this case? Or maybe just leave it as <leader> which
everybody who sets mapleader should know. In case it's not space, I
would leave it as it is now, as this way it's most useful to new
users...

Best,
 Mika

Re: [Vim-latex-devel] Bug with mapleader = " "

[ZyX <zy...@np...>]

Ответ на сообщение «[Vim-latex-devel] Bug with mapleader = " "», 
присланное в 23:26:23 07 октября 2010, Четверг.
Отправитель: Mika Fischer:

What problems do you have? If I do ``let g:mapleader="<Space>"'' before loading 
tex file, everything works as expected. Maybe you tried to set g:mapleader to 
literal space? I think that ``g:mapleader'' should be replaced but not with 
``<Leader>'' but with ``g:latex_suite_mapleader'' or something like that.

Текст сообщения:
> Hi,
> 
> there's a bug with vim-latex, when setting g:mapleader to <space>. The
> compile and view commands etc. get bound to "ll", "lv", and so on
> instead of "<space>ll", "<space>lv", and so on. Needless to say this
> messes things up quite a bit. The attached patch fixes this problem.
> 
> Please consider applying it.
> 
> Best regards,
>  Mika

Re: [Vim-latex-devel] Bug with mapleader = " "

[Mika F. <mik...@zo...>]

On Thu, Oct 7, 2010 at 22:17, ZyX <zy...@np...> wrote:
> What problems do you have? If I do ``let g:mapleader="<Space>"'' before loading
> tex file, everything works as expected. Maybe you tried to set g:mapleader to
> literal space?

Yes, I did. I was under the impression that "<space>" would not work.
I found some links to that effect:
http://stackoverflow.com/questions/446269/can-i-use-space-as-mapleader-in-vim
http://www.reddit.com/r/vim/comments/dh4u5/let_mapleader_space/

I have never tried it though. Maybe it's also an issue with missing quotes...

In any case the way vim-latex set the mappings was broken. I just
changed it so that the behavior stays the same except for my problem.

> I think that ``g:mapleader'' should be replaced but not with
> ``<Leader>'' but with ``g:latex_suite_mapleader'' or something like that.

I did not want to change this. But I agree it would make a lot of
sense. Maybe this variable could then default to <Leader> to keep the
current behavior?
Also maybe an option not to set those mappings and let users set their
own mappings would be useful.

Best,
 Mika

Re: [Vim-latex-devel] Bug with mapleader = " "

[ZyX <zy...@np...>]

Ответ на сообщение «Re: [Vim-latex-devel] Bug with mapleader = " "», 
присланное в 01:00:23 08 октября 2010, Пятница.
Отправитель: Mika Fischer:

> Also maybe an option not to set those mappings and let users set their
> own mappings would be useful.
It is the most useful option: I have to place
    function IMAP(...)
    endfunction
to my ftplugin/tex.vim in order not to have those very annoying insert mode 
mappings. Attached patch adds an option `g:latex_suite_omit_imap' that forbids 
using all IMAPs.

Текст сообщения:
> On Thu, Oct 7, 2010 at 22:17, ZyX <zy...@np...> wrote:
> > What problems do you have? If I do ``let g:mapleader="<Space>"'' before
> > loading tex file, everything works as expected. Maybe you tried to set
> > g:mapleader to literal space?
> 
> Yes, I did. I was under the impression that "<space>" would not work.
> I found some links to that effect:
> http://stackoverflow.com/questions/446269/can-i-use-space-as-mapleader-in-v
> im http://www.reddit.com/r/vim/comments/dh4u5/let_mapleader_space/
> 
> I have never tried it though. Maybe it's also an issue with missing
> quotes...
> 
> In any case the way vim-latex set the mappings was broken. I just
> changed it so that the behavior stays the same except for my problem.
> 
> > I think that ``g:mapleader'' should be replaced but not with
> > ``<Leader>'' but with ``g:latex_suite_mapleader'' or something like that.
> 
> I did not want to change this. But I agree it would make a lot of
> sense. Maybe this variable could then default to <Leader> to keep the
> current behavior?
> Also maybe an option not to set those mappings and let users set their
> own mappings would be useful.
> 
> Best,
>  Mika
> 
> ---------------------------------------------------------------------------
> --- Beautiful is writing same markup. Internet Explorer 9 supports
> standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
> Spend less time writing and  rewriting code and more time creating great
> experiences on the web. Be a part of the beta today.
> http://p.sf.net/sfu/beautyoftheweb
> _______________________________________________
> Vim-latex-devel mailing list
> Vim...@li...
> https://lists.sourceforge.net/lists/listinfo/vim-latex-devel