#68 Movie Rating Bug

closed-fixed
nobody
None
5
2008-03-07
2008-02-07
No

When editing a movie from your current collection, if the rating is changed to a number > 10, once the change is saved the View tab displays the movie with the specified amount of stars.

For example, if a movie is edited to have 99 stars, the statement checking for a rating > 10 is missed and 99 stars will be displayed in the view. Of course, data lookup can't be set to "overwrite" in which case it will pull the rating from imdb and this bug will be missed.

We are currently working on a fix for this bug and will post it here when we have found a solution.

Attached are some screenshots highlighting my example above.

Regards,
cgoodloe

Discussion

  • Andreas Goetz

    Andreas Goetz - 2008-02-07

    Logged In: YES
    user_id=391980
    Originator: NO

    How should that happen and why should smbd do that?

     
  • Chris Goodloe

    Chris Goodloe - 2008-02-14

    Code changes to "function.html_rating.php

     
  • Chris Goodloe

    Chris Goodloe - 2008-02-14

    Logged In: YES
    user_id=1996430
    Originator: YES

    The fix included below, handles the case where a user enters a movie rating > 10, whether by mistake or intentionally, when editing data for a movie. This fix prevents the possibility of seeing a page full of stars when viewing the movie, under the “view” tab.

    Edit function.html_rating.php, located in videodb\lib\smarty\custom, by adding the following line of code at or around line 52.

    if ($value > 10) $value = 10;

    This needs to be added just before the looping control variable, $rcv, is set.

    A screen shot has been attached as an example.

    Regards,
    cgoodloe

    File Added: MovieRatingBugFix.JPG

     
  • Chris Goodloe

    Chris Goodloe - 2008-02-14
    • status: open --> open-fixed
     
  • Andreas Goetz

    Andreas Goetz - 2008-03-07
    • status: open-fixed --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks