#46 Fix for Bug Report "... REL file write bug - ID: 3429401"

v2.3
closed-accepted
nobody
None
2011-12-17
2011-11-05
Greg King
No

Summary: A colon (as data) in a Position command always positions to record 58, instead of the desired record.

This patch file:
1) Fixes the colon bug.
2) Fixes a (related) buffer-overrun bug. (When the Position command is short, default values are used. They are written into the command buffer. But, that buffer is as short as the command. Therefore, the values are stored beyond the end of the buffer.)
3) Improves the debug messages (for example, we can see the difference between the 1581 drive's "b-r" and "b-R" commands).
4) Improves the code efficiency throughout the vdrive-command module.

Discussion

  • Greg King

    Greg King - 2011-11-05

    Fixes colon bugs in VDrive REL Position command.

     
  • gpz

    gpz - 2011-12-14
    • status: open --> pending-accepted
     
  • gpz

    gpz - 2011-12-14

    applied to trunk (r24993)

     
  • Greg King

    Greg King - 2011-12-17
    • status: pending-accepted --> closed-accepted
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks