#455 Alt-w doesn't work right

v2.4.x
closed-duplicate
None
Windows
User Interface
2013-08-12
2013-07-18
No

Windows vsid.exe warpmode (alt-w) should be like a fast-forward feature,
but all it does is garble the audio output and doesn't speed up that much really.
(watch the seconds counter when alt-w is pressed)

Discussion

  • derrick inksley

    derrick inksley - 2013-07-20

    I found out that alt-w is getting picked up by WM_COMMAND in vsidui.c ~line 880 but theres nothing there to handle or look for the alt-w.

     
  • gpz

    gpz - 2013-08-11

    that doesnt only not work in 2.4, but also current (2.4.x) right?

    ok it doesnt. the problem seems to lie in how the keyboard accelerators are implemented - infact alt+w works exactly like it should, but it would repeatedly switch warpmode on/off when pressed continuosly, and since vsid is much faster than the other emulators, even tapping alt+w wont permanently enable warpmode. its not just an issue in vsid, it should also work differently in the other emulators (wait for the key released)

     
    Last edit: gpz 2013-08-11
  • gpz

    gpz - 2013-08-11
    • summary: Windows vsid.exe alt-w doesn't work right --> Alt-w doesn't work right
    • assigned_to: Marco van den Heuvel
    • Version: v2.4 --> v2.4.x
    • Category: vsid --> User Interface
     
  • derrick inksley

    derrick inksley - 2013-08-11

    Yes, it happens in 2.x - current.

    Thats what I thought at first, that pressing alt-w was toggling it on/off very fast, but if you look more closely at the code, (and also realize that any alt+key combination causes the same behavior), you'll notice that the keyboard shortcuts, such as C64/Win_shortcuts.vsc, aren't even loaded for vsid.
    The reason why it goes "a little bit faster" when alt-w or alt+anything is pressed, is the case WM_COMMAND: at around line 880, basically vsync_suspend_speed_eval(); is being called repeatedly. (which clears the sound buffers)

    So heres the problem, simply put:
    1: vsidui.c doesn't use the uikeyboard.c/h to load the accelerators (alt-key commands) from win_shortcuts.vsc
    2: a separate win_shortcuts.vsc needs to be made for vsid

    Maybe thats too much work for just 1 alt-key combination? So, why don't we just create a single-key fast-forward button? I did this, and this is how I did it - see attached patch file.

    How it works: (similar to the 'I' command)
    'w' key held down=fast forward. 'w' released, normal

     
  • gpz

    gpz - 2013-08-12

    ok, so this is infact a duplicate of #452 - the proper solution is to create a new seperated codepath for loading the hotkeys

     
  • gpz

    gpz - 2013-08-12
    • status: open --> closed-duplicate
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks