Re: [Vfs-devel] (no subject)
Status: Alpha
Brought to you by:
eesa
From: Tony K. <tk...@ca...> - 2000-07-25 17:18:55
|
----- Original Message ----- From: "Abdul-Wahid Paterson" <ee...@we...> To: <vfs...@li...> Sent: Tuesday, July 25, 2000 9:45 AM Subject: Re: [Vfs-devel] (no subject) > Hi Tony, > > > Well this message is a little later than I said it would be. That's the bad > > thing about your company letting you work at home. Sometings you forget when > > to stop working and your work through the entire weekend when you should > > have been in NJ visiting your girlfriend... Or maybe I'm the only one with > > this problem :) > > Well, I live with my wife so I don't get the chance to forget her. > Sometimes I do seem to lose myself in my work for a few hours but my wife > would quickly make me snap out of it. > > > Anyway, I looked over the code and noticed that all of the > > PGSQL based database code is still in the main files. Things like the > > transaction code. This isn't a problem for the MySQL code since it now > > Yes I know... > > > supports transactions (however minimal the support may be). But other > > servers don't support that. I thought we were going to do a db_wrapper.php > > file for each database and have all the db calls from there. So we would > > have pg_db_wrapper.php, mysql_db_wrapper.php .. etc.. and in each file there > > would be the same functions but with different code to handle that databases > > functions. Like in the upload.php file just include <db>_db_wrapper.php and > > call an Handle_Upload_File($file_name); or something along those lines. > > Yes. This is really what we want to do. However, I wanted to work it out > slowly between the two of us so that we build up a good structure of the > code. I mean, most of the code should be the same for all databases as the > SQL statements would be the same and the DBI takes care of the rest. The > differences come with the BLOB upload stuff and also with sequences. I am > not familiar with how MySQL does sequences (enlighten me) but I know that Are you referring to auto incrementing numbers? > Oracle does them differently to Postgres. > > I think that what we should do is set up the class.DBD::mysql and start by > looking at how we can do the Administration stuff. Actually, if you start > looking at that I will look at sorting out the pg_upload/pg_download > functions and moving them into the pg_wrapper.inc.php3. What do you think? Sounds like a good place to start. I'll start building the admin functions for mySQL into the mysql_db_wrapper.php file. Keeping all the same function names that you've already used in the admin php scripts. We can see how close the code comes to what is already there. Regards, Tony Kirk |