[vde-users] Missing termination of option arrays

[<ni...@ly...>]

[ I hope this is a good place to send patches and bug reports. I don't
  plan to get deeply involved in vde development, so I'd prefer not
  subscribing to the -devel list, which as far as I understand is a
  members only list. ]

Some of the arrays passed to getopt_long have no proper termination.
E.g., vde_l3 --version crashes for me. Patch below. Also the logic in
vde_switch and kvde_switch looks a bit fishy; it's not obvious to me if
they add terminator or not.

Regards,
/Niels

Index: src/unixcmd.c
===================================================================
--- src/unixcmd.c       (revision 579)
+++ src/unixcmd.c       (working copy)
@@ -56,6 +56,7 @@
                {"rcfile", 1, 0, 'f'},
                {"sock", 1, 0, 's'},
                {"verbose", 0, 0, 'v'},
+               {NULL, 0, 0, 0}
        };
        int c;
        while ((c=getopt_long (argc, argv, "f:s:v",
Index: src/vde_autolink.c
===================================================================
--- src/vde_autolink.c  (revision 579)
+++ src/vde_autolink.c  (working copy)
@@ -1329,6 +1329,7 @@
                {"mgmtmode",    1, 0, MGMTMODEARG},
                {"sock",        1, 0, 's'},
                {"switchmgmt",  1, 0, 'S'},
+               {NULL, 0, 0, 0}
        };
        progname=basename(argv[0]);
 
Index: src/vde_l3/vde_l3.c
===================================================================
--- src/vde_l3/vde_l3.c (revision 579)
+++ src/vde_l3/vde_l3.c (working copy)
@@ -1324,6 +1324,7 @@
                {"vdeplug", 1, 0, 'v'},
                {"mgmt", 1, 0, 'M'},
 //TODO         {"daemon",0 , 0,'d'},
+               {NULL, 0, 0, 0},
        };
        progname=strdup(argv[0]);
        VDEROUTER.route_table = NULL;

-- 
Niels Möller. PGP-encrypted email is preferred. Keyid C0B98E26.
Internet email is subject to wholesale government surveillance.