Am Dienstag, 28. August 2001 20:20 schrieb Christophe Thil:
> Hi All,
>
> (deutsch oder englisch jetzt? ;))
fine ;-)
> I just uploaded the skinning support to the cvs.
good
> Well, it works but I know that the code needs to be cleaned and more
> variable checks, especially for the skin directory scanning
> mechanism, should be added; perhaps I'll do it tonight...
> At current, only the login form uses the new mechanism.
Chris, the first thing I noticed is that you use PHP4 :-)
So, right with the first commit we are at a desicion:
PHP3 only or already PHP4?
pro PHP3:
+ Runs on even old installations
+ is compatible with PHP4
+ PHP4 doesn't provide functionality that we urgently need-so why restrict to
PHP4
+ has some small functionality that is not available in PHP4 (which we don't
need - imho)
pro PHP4:
+ let's use the new syntax and easy coding style/readability
(if someone searches through the code, I already made some statments there)
Any other pros?
From my point of view, we can use PHP4 (even if I then have to update my
server)
What do the others think?
PS:
Jonatan: Can you please subscribe to the list too as all the others have
subscribed already?
Philipp
|