|
From: Jeroen N. W. <jn...@xs...> - 2004-08-25 12:47:42
|
Index: include/valgrind.h
===================================================================
RCS file: /home/kde/valgrind/include/valgrind.h,v
retrieving revision 1.26
diff -u -r1.26 valgrind.h
--- include/valgrind.h 19 Jun 2004 18:12:35 -0000 1.26
+++ include/valgrind.h 25 Aug 2004 12:45:36 -0000
@@ -171,7 +171,7 @@
/* Allow printfs to valgrind log. */
VG_USERREQ__PRINTF = 0x1401,
- VG_USERREQ__PRINTF_BACKTRACE = 0x1402,
+ VG_USERREQ__PRINTF_BACKTRACE = 0x1402
} Vg_ClientRequest;
#ifndef __GNUC__
|
|
From: Tom H. <th...@cy...> - 2004-08-25 13:26:04
|
In message <610...@we...>
Jeroen N. Witmond <jn...@xs...> wrote:
> /* Allow printfs to valgrind log. */
> VG_USERREQ__PRINTF = 0x1401,
> - VG_USERREQ__PRINTF_BACKTRACE = 0x1402,
> + VG_USERREQ__PRINTF_BACKTRACE = 0x1402
> } Vg_ClientRequest;
Thanks for that. I've committed your fix.
Tom
--
Tom Hughes (th...@cy...)
Software Engineer, Cyberscience Corporation
http://www.cyberscience.com/
|
|
From: Dennis L. <pla...@tz...> - 2004-08-25 13:27:14
|
Interesting, but why ? A comma at the end of enumerator list is explicitly allowed by ISO 9899 6.7.2.2-1 (mine is from 04/99 or did I miss some recent changes ?) greets Dennis Am Mi, den 25.08.2004 schrieb Jeroen N. Witmond um 14:47: > Index: include/valgrind.h > =================================================================== > RCS file: /home/kde/valgrind/include/valgrind.h,v > retrieving revision 1.26 > diff -u -r1.26 valgrind.h > --- include/valgrind.h 19 Jun 2004 18:12:35 -0000 1.26 > +++ include/valgrind.h 25 Aug 2004 12:45:36 -0000 > @@ -171,7 +171,7 @@ > > /* Allow printfs to valgrind log. */ > VG_USERREQ__PRINTF = 0x1401, > - VG_USERREQ__PRINTF_BACKTRACE = 0x1402, > + VG_USERREQ__PRINTF_BACKTRACE = 0x1402 > } Vg_ClientRequest; > > #ifndef __GNUC__ > > > > ------------------------------------------------------- > SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media > 100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33 > Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift. > http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285 > _______________________________________________ > Valgrind-users mailing list > Val...@li... > https://lists.sourceforge.net/lists/listinfo/valgrind-users > |
|
From: Tom H. <th...@cy...> - 2004-08-25 14:10:40
|
In message <109...@sp...>
Dennis Lubert <pla...@tz...> wrote:
> Interesting, but why ? A comma at the end of enumerator list is
> explicitly allowed by ISO 9899 6.7.2.2-1 (mine is from 04/99 or did I
> miss some recent changes ?)
You've only given part of the standard number so I can't be sure, but
given the date I assume what you have is ISO 9899:1999, commonly known
as C99. You're quite right that a trailing comma is allowed by that.
The issue is that ISO 9899:1990, commonly known as C89 or C90, does
not allow it, so older compilers will complain.
Tom
--
Tom Hughes (th...@cy...)
Software Engineer, Cyberscience Corporation
http://www.cyberscience.com/
|