|
From: Mike C. <ma...@mc...> - 2019-09-09 13:10:03
|
The Valgrind Git repository at https://sourceware.org/git/?p=valgrind.git has a VALGRIND_3_14_0 tag, but no tag corresponding to the 3.15.0 release. It looks like the tag should reference 608cb11914e5f23d0fc12c61dad29c5c7952a1de. Is that correct? Thanks. Mike. |
|
From: Mark W. <ma...@kl...> - 2019-09-10 11:18:51
|
Hi Mike, On Mon, 2019-09-09 at 14:09 +0100, Mike Crowe wrote: > The Valgrind Git repository at > https://sourceware.org/git/?p=valgrind.git > has a VALGRIND_3_14_0 tag, but no tag corresponding to the 3.15.0 > release. > It looks like the tag should reference > 608cb11914e5f23d0fc12c61dad29c5c7952a1de. Is that correct? Yeah, it is slightly ambiguous, since we have a chicken and egg problem :) The NEWS file has a git commit hash describing the commit that is the particular version. But then of course that is committed first before making the release, creating... a new hash. But I think you are correct that the official release tar ball was created from this (second) hash 608cb11914e5f23d0fc12c61dad29c5c7952a1de. Julian would you mind creating a signed tag for this commit? Using the same pgp key you used to sign the release tar ball? git tag -s -m "valgrind 3.15.0 release" VALGRIND_3_15_0 \ 608cb11914e5f23d0fc12c61dad29c5c7952a1de git push --tags We could also allow lightweight tags on the sourceware repo, but it seems better if the release master creates a full signed tag to make sure the tag and release tar ball are created from the same source. Cheers, Mark |
|
From: Julian S. <js...@ac...> - 2019-09-16 05:26:38
|
Hi Mark, > Julian would you mind creating a signed tag for this commit? > Using the same pgp key you used to sign the release tar ball? > > git tag -s -m "valgrind 3.15.0 release" VALGRIND_3_15_0 \ > 608cb11914e5f23d0fc12c61dad29c5c7952a1de > git push --tags Done! J |