|
From: Maarten L. <m.b...@gm...> - 2011-01-20 14:12:58
Attachments:
readpdb.patch
|
On ubuntu egrep is installed in /bin instead of /usr/bin. Having a space in the pathname currently also fails. Both issues are fixed with this small code change. --- I guess that having a ' in pathname or backslashes would still fail, but they probably occur a lot less. Backslash is an illegal character in windows so I doubt wine will have to worry about that much. |
|
From: Konstantin T. <an...@ya...> - 2011-01-20 14:23:55
|
20.01.2011, 17:12, "Maarten Lankhorst" <m.b...@gm...>: > On ubuntu egrep is installed in /bin instead of /usr/bin. On Mandriva too. Maybe it's better to use something like `which egrep` instead of hardcoded paths? -- Regards, Konstantin |
|
From: Maarten L. <m.b...@gm...> - 2011-01-20 16:20:02
|
Hi Konstantin, Op 20-01-11 15:23, Konstantin Tokarev schreef: > > 20.01.2011, 17:12, "Maarten Lankhorst"<m.b...@gm...>: >> On ubuntu egrep is installed in /bin instead of /usr/bin. > On Mandriva too. > > Maybe it's better to use something like `which egrep` instead of hardcoded paths? > I assumed there was a reason the path was used, if I used which egrep I might as well just remove the path part and change "/usr/bin/egrep" to "egrep". Also seems weird it calls sh -c since system would already call that. Maybe I'll just remove that part too. Cheers, Maarten |