|
From: Mark W. <ma...@kl...> - 2021-03-15 12:34:18
|
Greetings. A first release candidate for 3.17.0 is available at https://sourceware.org/pub/valgrind/valgrind-3.17.0.RC1.tar.bz2 (md5 = 9df201b3461a1709993ffc50d0920bd7) Please give it a try on platforms that are important for you. If no serious issues are reported, the 3.17.0 final release will happen on 19 March, that is, on Friday of this week. |
|
From: Mark W. <ma...@kl...> - 2021-03-15 16:14:25
|
Hi Carl, On Mon, 2021-03-15 at 09:05 -0700, Carl Love wrote: > I am seeing issues on various power platforms. > > Power 8 BE > > gcc --version > gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5) > > more /etc/os-release > NAME=Fedora > VERSION="27 (Server Edition)" > ID=fedora > VERSION_ID=27 > PRETTY_NAME="Fedora 27 (Server Edition)" > ANSI_COLOR="0;34" > CPE_NAME="cpe:/o:fedoraproject:fedora:27" > HOME_URL="https://fedoraproject.org/" > SUPPORT_URL=" > https://fedoraproject.org/wiki/Communicating_and_getting_help" > BUG_REPORT_URL="https://bugzilla.redhat.com/" > REDHAT_BUGZILLA_PRODUCT="Fedora" > REDHAT_BUGZILLA_PRODUCT_VERSION=27 > REDHAT_SUPPORT_PRODUCT="Fedora" > REDHAT_SUPPORT_PRODUCT_VERSION=27 > PRIVACY_POLICY_URL=" > https://fedoraproject.org/wiki/Legal:PrivacyPolicy" > VARIANT="Server Edition" > VARIANT_ID=server > > I am getting the following error while running make regtest > > leak-pool-4: valgrind ./leak-pool 4 > leak-pool-5: valgrind ./leak-pool 5 > leak-segv-jmp: (skipping, prereq failed: ! ../../tests/os_test > darwin && ! ../../tests/arch_test mips32 && ! > ../../tests/arch_test > ppc64) > leak-tree: valgrind -q --leak-check=full --leak- > resolution=high ./leak-tree > leak_cpp_interior: valgrind --leak-check=summary --leak-check- > heuristics=multipleinheritance,stdstring,newarray,length64 -- > suppressions=libstdc++.supp ./leak_cpp_interior > -- Running tests in memcheck/tests/linux ------------------------ > -- > ---- > brk: valgrind ./brk > capget: valgrind ./capget > /bin/sh: ./debuginfod-check.pl: No such file or directory > prereq returned 127: ./debuginfod-check.pl > ...checking makefile consistency > ...checking header files and include directives > make: *** [Makefile:1367: regtest] Error 1 Unfortunately debuginfod-check.pl was missing. I just added it: https://sourceware.org/git/?p=valgrind.git;a=commit;h=3751e963fab1d644508a9c25b0f147ad609d5dff > I see the same error on a Power 9 > > more /etc/os-release > NAME="Ubuntu" > VERSION="18.04.5 LTS (Bionic Beaver)" > ID=ubuntu > ID_LIKE=debian > PRETTY_NAME="Ubuntu 18.04.5 LTS" > VERSION_ID="18.04" > HOME_URL="https://www.ubuntu.com/" > SUPPORT_URL="https://help.ubuntu.com/" > BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/" > PRIVACY_POLICY_URL=" > https://www.ubuntu.com/legal/terms-and-policies/privacy-poli > cy" > VERSION_CODENAME=bionic > UBUNTU_CODENAME=bionic > > > I am seeing compilation issues on Power 8LE > > gcc --version > gcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0 > > NAME="Ubuntu" > VERSION="20.04.1 LTS (Focal Fossa)" > ID=ubuntu > ID_LIKE=debian > PRETTY_NAME="Ubuntu 20.04.1 LTS" > VERSION_ID="20.04" > HOME_URL="https://www.ubuntu.com/" > SUPPORT_URL="https://help.ubuntu.com/" > BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/" > PRIVACY_POLICY_URL=" > https://www.ubuntu.com/legal/terms-and-policies/privacy-policy" > VERSION_CODENAME=focal > UBUNTU_CODENAME=focal > > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > error: expected expression before ‘_Static_assert’ > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > instead.") > | ^~ > ~~~~~~~~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:1112:24: > note: in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > 1112 | # define MPI_UB > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_UB, MPI_Type_create_resized); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > libmpiwrap.c:281:19: note: in expansion of macro ‘MPI_UB’ > 281 | else if (ty == MPI_UB) fprintf(f,"UB"); > | ^~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > error: expected expression before ‘_Static_assert’ > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > instead.") > | ^~ > ~~~~~~~~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:1113:24: > note: in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > 1113 | # define MPI_LB > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_LB, MPI_Type_create_resized); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > libmpiwrap.c:282:19: note: in expansion of macro ‘MPI_LB’ > 282 | else if (ty == MPI_LB) fprintf(f,"LB"); > | ^~~~~~ > libmpiwrap.c: In function ‘showCombiner’: > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > error: expected expression before ‘_Static_assert’ > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > instead.") > | ^~ > ~~~~~~~~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:743:46: note: > in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > 743 | # define MPI_COMBINER_HVECTOR_INTEGER > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_COMBINER_HVECTOR_INTEGER, > MPI_COMBINER_HVECTOR); > | ^~~~~~~~~~~~~ > ~~~~~~~~~~~~~~~~~~~ > libmpiwrap.c:354:12: note: in expansion of macro > ‘MPI_COMBINER_HVECTOR_INTEGER’ > 354 | case MPI_COMBINER_HVECTOR_INTEGER: fprintf(f, > "HVECTOR_INTEGER"); break; > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > error: expected expression before ‘_Static_assert’ > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > instead.") > | ^~ > ~~~~~~~~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:743:46: note: > in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > 743 | # define MPI_COMBINER_HVECTOR_INTEGER > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_COMBINER_HVECTOR_INTEGER, > MPI_COMBINER_HVECTOR); > | ^~~~~~~~~~~~~ > ~~~~~~~~~~~~~~~~~~~ > libmpiwrap.c:354:12: note: in expansion of macro > ‘MPI_COMBINER_HVECTOR_INTEGER’ > 354 | case MPI_COMBINER_HVECTOR_INTEGER: fprintf(f, > "HVECTOR_INTEGER"); break; > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > libmpiwrap.c:354:40: error: expected expression before ‘:’ token > 354 | case MPI_COMBINER_HVECTOR_INTEGER: fprintf(f, > "HVECTOR_INTEGER"); break; > | ^ > In file included from libmpiwrap.c:116: > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > error: expected expression before ‘_Static_assert’ > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > instead.") > | ^~ > ~~~~~~~~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:744:47: note: > in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > 744 | # define MPI_COMBINER_HINDEXED_INTEGER > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_COMBINER_HINDEXED_INTEGER, > MPI_COMBINER_HINDEXED); > | ^~~~~~~~~~~~ > ~~~~~~~~~~~~~~~~~~~~ > libmpiwrap.c:359:12: note: in expansion of macro > ‘MPI_COMBINER_HINDEXED_INTEGER’ > 359 | case MPI_COMBINER_HINDEXED_INTEGER: fprintf(f, > "HINDEXED_INTEGER"); break; > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > error: expected expression before ‘_Static_assert’ > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > instead.") > | ^~ > ~~~~~~~~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:744:47: note: > in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > 744 | # define MPI_COMBINER_HINDEXED_INTEGER > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_COMBINER_HINDEXED_INTEGER, > MPI_COMBINER_HINDEXED); > | ^~~~~~~~~~~~ > ~~~~~~~~~~~~~~~~~~~~ > libmpiwrap.c:359:12: note: in expansion of macro > ‘MPI_COMBINER_HINDEXED_INTEGER’ > 359 | case MPI_COMBINER_HINDEXED_INTEGER: fprintf(f, > "HINDEXED_INTEGER"); break; > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > libmpiwrap.c:359:41: error: expected expression before ‘:’ token > 359 | case MPI_COMBINER_HINDEXED_INTEGER: fprintf(f, > "HINDEXED_INTEGER"); break; > | ^ > In file included from libmpiwrap.c:116: > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > error: expected expression before ‘_Static_assert’ > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > instead.") > | ^~ > ~~~~~~~~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:745:45: note: > in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > 745 | # define MPI_COMBINER_STRUCT_INTEGER > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_COMBINER_STRUCT_INTEGER, > MPI_COMBINER_STRUCT); > | ^~~~~~~~~~~~~~ > ~~~~~~~~~~~~~~~~~~ > libmpiwrap.c:366:12: note: in expansion of macro > ‘MPI_COMBINER_STRUCT_INTEGER’ > 366 | case MPI_COMBINER_STRUCT_INTEGER: fprintf(f, > "STRUCT_INTEGER"); break; > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > error: expected expression before ‘_Static_assert’ > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > instead.") > | ^~ > ~~~~~~~~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:745:45: note: > in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > 745 | # define MPI_COMBINER_STRUCT_INTEGER > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_COMBINER_STRUCT_INTEGER, > MPI_COMBINER_STRUCT); > | ^~~~~~~~~~~~~~ > ~~~~~~~~~~~~~~~~~~ > libmpiwrap.c:366:12: note: in expansion of macro > ‘MPI_COMBINER_STRUCT_INTEGER’ > 366 | case MPI_COMBINER_STRUCT_INTEGER: fprintf(f, > "STRUCT_INTEGER"); break; > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > libmpiwrap.c:366:39: error: expected expression before ‘:’ token > 366 | case MPI_COMBINER_STRUCT_INTEGER: fprintf(f, > "STRUCT_INTEGER"); break; > | ^ > libmpiwrap.c: In function ‘extentOfTy’: > libmpiwrap.c:462:8: warning: implicit declaration of function > ‘PMPI_Type_extent’; did you mean ‘MPI_Type_extent’? [-Wimplicit- > function-declaration] > 462 | r = PMPI_Type_extent(ty, &n); > | ^~~~~~~~~~~~~~~~ > | MPI_Type_extent > In file included from libmpiwrap.c:116: > libmpiwrap.c: In function ‘walk_type’: > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > error: expected expression before ‘_Static_assert’ > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > instead.") > | ^~ > ~~~~~~~~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:1113:24: > note: in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > 1113 | # define MPI_LB > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_LB, MPI_Type_create_resized); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > libmpiwrap.c:736:17: note: in expansion of macro ‘MPI_LB’ > 736 | if (ty == MPI_LB || ty == MPI_UB) > | ^~~~~~ > make[2]: *** [Makefile:716: libmpiwrap_ppc64le_linux_so- > libmpiwrap.o] Error 1 > make[2]: Leaving directory '/home/carll/Valgrind/valgrind- > 3.17.0.RC1/mpi' > make[1]: *** [Makefile:855: check-recursive] Error 1 > make[1]: Leaving directory '/home/carll/Valgrind/valgrind- > 3.17.0.RC1' > make: *** [Makefile:1149: check] Error 2 > > I will dig into this a bit more and see if I can find a fix for the > error. I will let you know. I just did a build on Fedora, and I am not seeing these issues. It might depend on the version of openmpi installed I assume. https://koji.fedoraproject.org/koji/buildinfo?buildID=1723501 Cheers, Mark |
|
From: Mark W. <ma...@kl...> - 2021-03-16 12:19:47
|
Hi Carl, On Mon, 2021-03-15 at 11:33 -0700, Carl Love wrote: > Will Schmidt posted an email with regards to the build issue: > > I think so.. we ran into a similar issue late last year, which I > think > we had determined was due to the MPI packages in the > environment. > The patch in comment #3 of this bugzilla helped us at that time. > https://bugs.kde.org/show_bug.cgi?id=401416 Thanks. That explains why I am not seeing it on Fedora, but you are seeing it on Ubuntu. OpenMPI4 disables MPI1 support by default, but fedora still enables it (for now). > I applied the MPI patch to the mainline git tree on the system where > I had the compile error. It fixed the compile issue. I applied the > patch to another system which didn't have the compile issue. The patch > did not break anything. As far as I can tell, the MPI patch is fine. It seems fine if MPI1 is removed. But I am not 100% sure if it is fine when you still have MPI1 support. I'll try and test it a bit. > I pulled the mainline git tree and retested on Power 8LE, Power 8BE, > Power 9, and prototype hardware. The regression tests all look fine > with the above mentioned MPI fix where needed. Nice. Thanks, Mark |
|
From: Paul F. <pj...@wa...> - 2021-03-16 20:08:14
|
On 3/15/21 1:33 PM, Mark Wielaard wrote: > Greetings. > > A first release candidate for 3.17.0 is available at > https://sourceware.org/pub/valgrind/valgrind-3.17.0.RC1.tar.bz2 > (md5 = 9df201b3461a1709993ffc50d0920bd7) > > Please give it a try on platforms that are important for you. If no > serious issues are reported, the 3.17.0 final release will happen on 19 > March, that is, on Friday of this week. Hi Please let me know if you'd prefer me to push the two small changes in the tests described below now, or to wait after 3.17 ships. On OS X 10.7.5 (Darwin 11.4.2), I've tried a bit harder than usual to get everything to build at least. I still have a lot of compiler problems. The last available XCode for this platform is too old for the current Valgrind source (it doen't support some of the asm opcodes). So I've been using macports clang (version 9 for the C code and 11 for the C++). There's a small issue building dhat/tests/copy.c, it just needs a '|| defined(VGO_darwin). none/tests/tls isn't building - a link error with the TLS variable "__thread int global;". Needs more investigation. ./tests/arm64_features.c doesn't compile: arm64_features.c:4:10: fatal error: 'sys/auxv.h' file not found #include <sys/auxv.h> ^~~~~~~~~~~~ I'm running the regression tests. They are very slow so I might net get them tonight. A+ Paul |
|
From: Mark W. <ma...@kl...> - 2021-03-16 23:29:09
|
Hi Paul, On Tue, Mar 16, 2021 at 09:07:56PM +0100, Paul Floyd wrote: > > On 3/15/21 1:33 PM, Mark Wielaard wrote: > > Greetings. > > > > A first release candidate for 3.17.0 is available at > > https://sourceware.org/pub/valgrind/valgrind-3.17.0.RC1.tar.bz2 > > (md5 = 9df201b3461a1709993ffc50d0920bd7) > > > > Please give it a try on platforms that are important for you. If no > > serious issues are reported, the 3.17.0 final release will happen on 19 > > March, that is, on Friday of this week. > > Please let me know if you'd prefer me to push the two small changes in the > tests described below now, or to wait after 3.17 ships. I think it would be good to get these small fixes in and do an RC2 (including the mpi build fix) to make sure things build out of the box on more setups. > On OS X 10.7.5 (Darwin 11.4.2), I've tried a bit harder than usual to get > everything to build at least. I still have a lot of compiler problems. The > last available XCode for this platform is too old for the current Valgrind > source (it doen't support some of the asm opcodes). So I've been using > macports clang (version 9 for the C code and 11 for the C++). > > There's a small issue building dhat/tests/copy.c, it just needs a '|| > defined(VGO_darwin). I assume because darwin, like solaris, doesn't have mempcpy. That should be fine. > none/tests/tls isn't building - a link error with the TLS variable "__thread > int global;". Needs more investigation. That doesn't ring a bell. > ./tests/arm64_features.c doesn't compile: > > arm64_features.c:4:10: fatal error: 'sys/auxv.h' file not found > #include <sys/auxv.h> > ^~~~~~~~~~~~ > Hmmm, that is for getauxval. That probably isn't available on Darwin. I don't immediately know how to replace that. Cheers, Mark |