|
From: Leonard m. <spa...@ya...> - 2003-06-11 17:41:50
|
I really like the new capability, ...except for all the prompting.
What do you think of a --gen-suppressions={yes|no|ask} option. "yes"
would generate suppressions without a prompt for every flagged issue,
and "ask" would do what yes does now. I just want it to dump
everything in a file and when it prompts me I have to sit there and
bang "y" on the keyboard.
A less desirable second choice would be to add another option to the
prompt. Currently we have "no this time", "yes this time", and
"no this time and for all future occurances". A "yes this time and for
all future occurances" would do it, but you'd still need to
answer that first prompt, even if you'd routed the valgrind output to a
file.
Thanks,
Randall
__________________________________
Do you Yahoo!?
Yahoo! Calendar - Free online calendar with sync to Outlook(TM).
http://calendar.yahoo.com
|
|
From: Alex I. <ale...@in...> - 2003-06-11 17:56:32
|
<!doctype html public "-//w3c//dtd html 4.0 transitional//en">
<html>
I agree completely with the first suggestion. Especially for some
of my apps that run as daemons and are cut off from tty completely
- there is no way to get the valgrind prompt and reply to it (all
valgrind output is going to a log file).
<p>Alex
<p>Leonard mckinley wrote:
<blockquote TYPE=CITE>I really like the new capability, ...except for all
the prompting.
<p>What do you think of a --gen-suppressions={yes|no|ask} option.
"yes"
<br>would generate suppressions without a prompt for every flagged issue,
<br>and "ask" would do what yes does now. I just want it to dump
<br>everything in a file and when it prompts me I have to sit there and
<br>bang "y" on the keyboard.
<p>A less desirable second choice would be to add another option to the
<br>prompt. Currently we have "no this time", "yes this time", and
<br>"no this time and for all future occurances". A "yes this time
and for
<br>all future occurances" would do it, but you'd still need to
<br>answer that first prompt, even if you'd routed the valgrind output
to a
<br>file.
<p>Thanks,
<p>Randall
<p>__________________________________
<br>Do you Yahoo!?
<br>Yahoo! Calendar - Free online calendar with sync to Outlook(TM).
<br><a href="http://calendar.yahoo.com">http://calendar.yahoo.com</a>
<p>-------------------------------------------------------
<br>This SF.NET email is sponsored by: eBay
<br>Great deals on office technology -- on eBay now! Click here:
<br><a href="http://adfarm.mediaplex.com/ad/ck/711-11697-6916-5">http://adfarm.mediaplex.com/ad/ck/711-11697-6916-5</a>
<br>_______________________________________________
<br>Valgrind-users mailing list
<br>Val...@li...
<br><a href="https://lists.sourceforge.net/lists/listinfo/valgrind-users">https://lists.sourceforge.net/lists/listinfo/valgrind-users</a></blockquote>
<pre>--
Alex G. Ivershen Inet Technologies, Inc.
Network Products Dept. 1500 N. Greenville Ave.
Inet Technologies Inc. Richardson, TX 75081
Phone: +1-469-330-4295 USA
"Computer games don't affect kids; I mean if Pac-Man affected us as kids, we'd
all be running around in darkened rooms, munching magic pills and listening to
repetitive electronic music." -- Kristian Wilson, Nintendo, Inc</pre>
</html>
|
|
From: Madhu M K. <mm...@ya...> - 2003-06-11 20:33:19
|
Hi,
Leonard mckinley <spa...@ya...> said:
> I really like the new capability, ...except for all the prompting.
>
> What do you think of a --gen-suppressions={yes|no|ask} option. "yes"
> would generate suppressions without a prompt for every flagged issue,
> and "ask" would do what yes does now. I just want it to dump
> everything in a file and when it prompts me I have to sit there and
> bang "y" on the keyboard.
I actually wrote up a different kind of --gen-suppressions. This one did
the following:
--gen-suppressions=yes/filename
If you gave it a filename, it would then peacefully keep accumulating
suppressions, keep a count of how many times that suppressions was
generated irrespective of context (eg. a glibc error that shows up from
diff location, same library's problem). And finally it would dump out
suppressions sorted by frequency. Max to min.
You then have to manually parse the suppression file to remove the
"real leaks". A rule of thumb that I've found works for me is that any
frequency > 20 is usually a library that I can do nothing about.
Let me cvs up to head, sync up the changes and post a patch.
Cheerio,
M
Madhu M Kurup /* Nemo Me Impune Lacessit */ mmk at yahoo-inc dt com
|
|
From: Madhu M. K. <mm...@ya...> - 2003-06-15 22:42:56
Attachments:
gen_suppressions_file.patch
|
Hi,
Leonard mckinley wrote:
>What do you think of a --gen-suppressions={yes|no|ask} option. "yes"
>would generate suppressions without a prompt for every flagged issue,
>and "ask" would do what yes does now. I just want it to dump
>everything in a file and when it prompts me I have to sit there and
>bang "y" on the keyboard.
Attached is a patch that does precisely that. It accumulates suppressions
and dumps them into a file, sorted by frequency at which they were hit
during the execution.
I've found this to be fairly useful by running through my programs
with the simplest startup/shutdown execution path. This captures all the
background noise. With the generated suppression file, I then try the
various options in the code to discover problems that I'm in a position to
fix. In addition, reading the low frequency count errors is a good idea :)
Could you apply this patch and let me know how it goes?
Cheerio,
M
Madhu M Kurup /* Nemo Me Impune Lacessit */ mmk at yahoo-inc dt com
|
|
From: Leonard m. <spa...@ya...> - 2003-06-16 13:48:17
|
> >What do you think of a --gen-suppressions={yes|no|ask} option.
> >"yes" would generate suppressions without a prompt for every
> >flagged issue, and "ask" would do what yes does now. I just want
> >it to dump everything in a file and when it prompts me I have to
> >sit there and bang "y" on the keyboard.
>
> Attached is a patch that does precisely that. It accumulates
> suppressions and dumps them into a file, sorted by frequency at
> which they were hit during the execution.
Works well, thanks! Just two buglets. The "ask" and "yes" cases are
reversed (that is, it asks when you say "yes", and doesn't ask when you
say "ask").
Also, --help doesn't tell you about the new-and-improved
--gen-suppressions syntax.
I notice that it dumps suppressions in separate files for separate
subprocesses/threads in "yes" mode, but I guess that's the expected
behavior.
Randall
__________________________________
Do you Yahoo!?
SBC Yahoo! DSL - Now only $29.95 per month!
http://sbc.yahoo.com
|
|
From: Madhu M K. <mm...@ya...> - 2003-06-16 18:09:20
|
Hi, Leonard mckinley <spa...@ya...> said: > > Works well, thanks! Just two buglets. The "ask" and "yes" cases are > reversed (that is, it asks when you say "yes", and doesn't ask when > you say "ask"). Aargh. Should have explained this better: --gen-suppressions=no (obvious) --gen-suppressions=yes (just like before, will ask you for each, dump to stdout) --gen-suppressions=filename (will create filename.pidX and dump there, no prompting at all) I wanted to maintain backward compat with the previous usage... Does that explain it? Cheerio, M Madhu M Kurup /* Nemo Me Impune Lacessit */ mmk at yahoo-inc dt com |
|
From: Leonard m. <spa...@ya...> - 2003-06-17 12:47:44
|
--- Madhu M Kurup <mm...@ya...> wrote: > Aargh. Should have explained this better: > > --gen-suppressions=no (obvious) > --gen-suppressions=yes (just like before, will ask you for each, dump to stdout) > --gen-suppressions=filename (will create filename.pidX and dump there, no prompting at all) > > I wanted to maintain backward compat with the previous usage... > > Does that explain it? Yes. Thanks. Randall __________________________________ Do you Yahoo!? SBC Yahoo! DSL - Now only $29.95 per month! http://sbc.yahoo.com |
|
From: Lee K. <lki...@cs...> - 2003-07-15 15:06:00
Attachments:
diffs2
|
Guys, any chance of this patch getting applied to HEAD? It makes the
--gen-suppressions functionality much more usable.
I've fixed up Madhu's original diff so it can be applied against CVS
HEAD and have run this on my apps... However due to the format of the
original diff, the changes since then, and the flakyness of SF's CVS
server it's not an identical copy of the original diff...
Anyway, attached in context diff format for your consideration.
Thanks, Lee.
Madhu M. Kurup writes:
> Hi,
>
> Leonard mckinley wrote:
> >What do you think of a --gen-suppressions={yes|no|ask} option. "yes"
> >would generate suppressions without a prompt for every flagged issue,
> >and "ask" would do what yes does now. I just want it to dump
> >everything in a file and when it prompts me I have to sit there and
> >bang "y" on the keyboard.
>
> Attached is a patch that does precisely that. It accumulates suppressions
> and dumps them into a file, sorted by frequency at which they were hit
> during the execution.
>
> I've found this to be fairly useful by running through my programs
> with the simplest startup/shutdown execution path. This captures all the
> background noise. With the generated suppression file, I then try the
> various options in the code to discover problems that I'm in a position to
> fix. In addition, reading the low frequency count errors is a good idea :)
>
> Could you apply this patch and let me know how it goes?
>
> Cheerio,
> M
>
> Madhu M Kurup /* Nemo Me Impune Lacessit */ mmk at yahoo-inc dt com
>
> [ original diff snipped ]
|