valgrind-users

[Valgrind-users] Current git fails to compile on macOS

[IMoL <im...@gm...>]

git-1f08787cf (of 11 April) fails to build on macOS:

m_syswrap/syswrap-generic.c:1797:26: error: variable has incomplete type
'struct vki_semid64_ds'
   struct vki_semid64_ds buf;
                         ^
m_syswrap/syswrap-generic.c:1797:11: note: forward declaration of 'struct
vki_semid64_ds'
   struct vki_semid64_ds buf;
          ^
m_syswrap/syswrap-generic.c:1798:8: error: no member named 'buf64' in
'union semun'
   arg.buf64 = &buf;
   ~~~ ^


Looks related to this commit from 1 April (git-54145019b):

"n-i-bz Fix possible stack trashing by semctl syscall wrapping"

Re: [Valgrind-users] Current git fails to compile on macOS

[Philippe W. <phi...@sk...>]

On Fri, 2018-04-13 at 05:56 -0400, IMoL wrote:
> git-1f08787cf (of 11 April) fails to build on macOS:
> 
> m_syswrap/syswrap-generic.c:1797:26: error: variable has incomplete type 'struct vki_semid64_ds'
>    struct vki_semid64_ds buf;
>                          ^
> m_syswrap/syswrap-generic.c:1797:11: note: forward declaration of 'struct vki_semid64_ds'
>    struct vki_semid64_ds buf;
>           ^
> m_syswrap/syswrap-generic.c:1798:8: error: no member named 'buf64' in 'union semun'
>    arg.buf64 = &buf;
>    ~~~ ^
> 
> 
> Looks related to this commit from 1 April (git-54145019b):
> 
> "n-i-bz Fix possible stack trashing by semctl syscall wrapping" 
Can you try the attached patch ?
Thanks
Philippe

Re: [Valgrind-users] Current git fails to compile on macOS

[IMoL <im...@gm...>]

Thank you Philippe.

That patch allows valgrind to compile on macOS.

Still doesn't work for me, mind you, but at least it compiles again :-)

- Andy

On Sat, Apr 14, 2018 at 12:24 PM, Philippe Waroquiers <
phi...@sk...> wrote:

> On Fri, 2018-04-13 at 05:56 -0400, IMoL wrote:
> > git-1f08787cf (of 11 April) fails to build on macOS:
> >
> > m_syswrap/syswrap-generic.c:1797:26: error: variable has incomplete
> type 'struct vki_semid64_ds'
> >    struct vki_semid64_ds buf;
> >                          ^
> > m_syswrap/syswrap-generic.c:1797:11: note: forward declaration of
> 'struct vki_semid64_ds'
> >    struct vki_semid64_ds buf;
> >           ^
> > m_syswrap/syswrap-generic.c:1798:8: error: no member named 'buf64' in
> 'union semun'
> >    arg.buf64 = &buf;
> >    ~~~ ^
> >
> >
> > Looks related to this commit from 1 April (git-54145019b):
> >
> > "n-i-bz Fix possible stack trashing by semctl syscall wrapping"
> Can you try the attached patch ?
> Thanks
> Philippe
>

Re: [Valgrind-users] Current git fails to compile on macOS

[Philippe W. <phi...@sk...>]

On Sat, 2018-04-14 at 13:37 -0400, IMoL wrote:
> Thank you Philippe.
> 
> That patch allows valgrind to compile on macOS.
thanks for the feedback, patch committed as
06cb991bcd9966b614cd672a7d6e26785f60f851

> 
> Still doesn't work for me, mind you, but at least it compiles again :-)
Someone with more Macos knowledge will have to step in ...

Philippe