|
From: Carl L. <ce...@us...> - 2022-02-10 17:24:43
|
Philippe, Mark:
On Wed, 2022-02-09 at 12:01 +0000, valgrind-testresults-
re...@li... wrote:
> Date: Wed, 09 Feb 2022 11:53:46 +0100
> From: Mark Wielaard <ma...@kl...>
> To: Philippe Waroquiers <phi...@sk...>,
> val...@li...
> Subject: Re: [Valgrind-testresults] 2022-02-09 03:00:04 UTC nightly
> build (gcc110, \S, ppc64)
> Message-ID: <007...@kl...
> >
> Content-Type: text/plain; charset="UTF-8"
>
> Hi Philippe,
>
> On Wed, 2022-02-09 at 03:03 +0000, Philippe Waroquiers wrote:
> > valgrind revision:
> > C compiler: gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-44)
> > GDB: GNU gdb (GDB) Red Hat Enterprise Linux 7.6.1-
> > 120.el7
> > Assembler: GNU assembler version 2.27-44.base.el7_9.1
> > C library: GNU C Library (GNU libc) stable release version
> > 2.17
> > uname -mrs: Linux 3.10.0-862.14.4.el7.ppc64 ppc64
> > Vendor version: CentOS Linux 7 (AltArch)
> >
> > Nightly build on gcc110 ( \S, ppc64 )
> > Started at 2022-02-09 03:00:04 UTC
> > Ended at 2022-02-09 03:03:42 UTC
> > Results differ from 24 hours ago
> >
> > Checking out Valgrind source tree ... done
> > Configuring valgrind ... done
> > Building valgrind ... failed
> >
> >
<snip>
>
> Could you take a look at what is really broken here? The log doesn't
> really make that clear.
I took a look and found the issue. There is a typo in an inline
assembly specification (00x7f140434 instead of 0x7f140434) that is
causing the assembler to error out. Here is the fix:
------------------
[PATCH] Powerpc: Fix typo in assembly code specification.
The extra 0 results in an assebler error:
Error: junk at end of line, first unrecognized character is `x'
---
coregrind/m_machine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/coregrind/m_machine.c b/coregrind/m_machine.c
index 089acee..7aa1513 100644
--- a/coregrind/m_machine.c
+++ b/coregrind/m_machine.c
@@ -1246,7 +1246,7 @@ Bool VG_(machine_get_hwcaps)( void )
if (VG_MINIMAL_SETJMP(env_unsup_insn)) {
have_isa_3_0 = False;
} else {
- __asm__ __volatile__(".long 00x7f140434":::"r20"); /* cnttzw r20,r24 */
+ __asm__ __volatile__(".long 0x7f140434":::"r20"); /* cnttzw r20,r24 */
}
// ISA 3.1 not supported on 32-bit systems
--
1.8.3.1
----------------------------------------------
I will commit the fix to Valgrind mainline. Will keep an eye on the
builds to make sure the issue is fixed.
Carl
|
|
From: Mark W. <ma...@kl...> - 2022-02-11 10:19:13
|
Hi Carl, On Thu, Feb 10, 2022 at 09:24:18AM -0800, Carl Love wrote: > I took a look and found the issue. There is a typo in an inline > assembly specification (00x7f140434 instead of 0x7f140434) that is > causing the assembler to error out. Here is the fix: > > ------------------ > [PATCH] Powerpc: Fix typo in assembly code specification. > > The extra 0 results in an assebler error: > Error: junk at end of line, first unrecognized character is `x' Thanks, that seems to have solved it. Odd this only was an issue for this rhel7 based builder. Apparently newer binutils accept the extra 0. Cheers, Mark |
|
From: Philippe W. <phi...@sk...> - 2022-02-11 10:27:34
|
Hello Mark and Carl, Thanks for having looked at this, sorry to not have been very active recently. I was intending to work on that this week-end (I have a lot/too many things to do at work these last months). Philippe On Fri, 2022-02-11 at 11:18 +0100, Mark Wielaard wrote: > Hi Carl, > > On Thu, Feb 10, 2022 at 09:24:18AM -0800, Carl Love wrote: > > I took a look and found the issue. There is a typo in an inline > > assembly specification (00x7f140434 instead of 0x7f140434) that is > > causing the assembler to error out. Here is the fix: > > > > ------------------ > > [PATCH] Powerpc: Fix typo in assembly code specification. > > > > The extra 0 results in an assebler error: > > Error: junk at end of line, first unrecognized character is `x' > > Thanks, that seems to have solved it. Odd this only was an issue for > this rhel7 based builder. Apparently newer binutils accept the extra 0. > > Cheers, > > Mark > |