|
From: <sv...@va...> - 2008-06-09 15:08:36
|
Author: bart
Date: 2008-06-09 16:08:22 +0100 (Mon, 09 Jun 2008)
New Revision: 8207
Log:
Commented out assert statements because of performance reasons.
Modified:
trunk/exp-drd/drd_thread.h
Modified: trunk/exp-drd/drd_thread.h
===================================================================
--- trunk/exp-drd/drd_thread.h 2008-06-09 12:43:20 UTC (rev 8206)
+++ trunk/exp-drd/drd_thread.h 2008-06-09 15:08:22 UTC (rev 8207)
@@ -168,8 +168,10 @@
static __inline__
Bool running_thread_is_recording(void)
{
+#if 0
tl_assert(0 <= (int)s_drd_running_tid && s_drd_running_tid < DRD_N_THREADS
&& s_drd_running_tid != DRD_INVALID_THREADID);
+#endif
return (s_threadinfo[s_drd_running_tid].synchr_nesting == 0
&& s_threadinfo[s_drd_running_tid].is_recording);
}
@@ -207,9 +209,11 @@
static __inline__
Segment* thread_get_segment(const DrdThreadId tid)
{
+#if 0
tl_assert(0 <= (int)tid && tid < DRD_N_THREADS
&& tid != DRD_INVALID_THREADID);
tl_assert(s_threadinfo[tid].last);
+#endif
return s_threadinfo[tid].last;
}
|
|
From: Nicholas N. <nj...@cs...> - 2008-06-10 22:09:27
|
On Mon, 9 Jun 2008 sv...@va... wrote: > Author: bart > Date: 2008-06-09 16:08:22 +0100 (Mon, 09 Jun 2008) > New Revision: 8207 > > Log: > Commented out assert statements because of performance reasons. I suggest adding a comment above those #if statements explaining this. Nick |
|
From: Bart V. A. <bar...@gm...> - 2008-06-12 13:11:55
|
On Wed, Jun 11, 2008 at 12:08 AM, Nicholas Nethercote <nj...@cs...> wrote: > On Mon, 9 Jun 2008 sv...@va... wrote: > >> Author: bart >> Date: 2008-06-09 16:08:22 +0100 (Mon, 09 Jun 2008) >> New Revision: 8207 >> >> Log: >> Commented out assert statements because of performance reasons. > > I suggest adding a comment above those #if statements explaining this. Good idea. By this time I have surrounded assert statements that were commented out because of performance reasons by #ifdef ENABLE_DRD_CONSISTENCY_CHECKS / #endif. Bart. |