|
From: Bart V. A. <bar...@gm...> - 2007-12-27 17:07:28
Attachments:
valgrind-2007-12-27b.patch
|
I know that not everyone uses the const keyword wherever possible, but I would appreciate if the Valgrind core would support programmers that follow this style. Currently it is not possible to pass pointers to const keys to the OSet-manipulating functions without having to cast away constness in order to avoid compiler errors. Can the attached patch please be reviewed and committed on the trunk ? Thanks, Bart Van Assche. |
|
From: Tom H. <to...@co...> - 2007-12-30 12:28:59
|
On 27/12/2007, Bart Van Assche <bar...@gm...> wrote: > I know that not everyone uses the const keyword wherever possible, but I > would appreciate if the Valgrind core would support programmers that follow > this style. Currently it is not possible to pass pointers to const keys to > the OSet-manipulating functions without having to cast away constness in > order to avoid compiler errors. Can the attached patch please be reviewed > and committed on the trunk ? Looks good to me - committed. Tom -- Tom Hughes (to...@co...) http://www.compton.nu/ |
|
From: Bart V. A. <bar...@gm...> - 2008-01-04 19:34:47
Attachments:
valgrind-2008-01-04.patch
|
On Dec 30, 2007 1:28 PM, Tom Hughes <to...@co...> wrote: > On 27/12/2007, Bart Van Assche <bar...@gm...> wrote: > > > I know that not everyone uses the const keyword wherever possible, but I > > would appreciate if the Valgrind core would support programmers that > follow > > this style. Currently it is not possible to pass pointers to const keys > to > > the OSet-manipulating functions without having to cast away constness in > > order to avoid compiler errors. Can the attached patch please be > reviewed > > and committed on the trunk ? > > Looks good to me - committed. > > Tom > Hello Tom, It seems that I overlooked that osets are also used in regression tests. Can you please apply the attached patch ? Thanks, Bart. |