|
From: Nicholas N. <nj...@ca...> - 2004-04-22 18:28:26
|
Hi, I think there is a bug in helper_IN and helper_OUT. Both of them trash %eflags, because they contain 'cmp' instructions. But they don't preserve the flags with pushf/popf, the way that helper_fstsw_AX does, for example. I figure nobody's noticed this before because IN and OUT are so rare. Can somebody else confirm my thinking? I'll commit a fix if so. N |
|
From: Dirk M. <dm...@gm...> - 2004-04-22 18:37:07
|
On Thursday 22 April 2004 20:28, Nicholas Nethercote wrote: > Can somebody else confirm my thinking? I'll commit a fix if so. You're right. |
|
From: Tom H. <th...@cy...> - 2004-04-22 18:39:07
|
In message <Pin...@ye...>
Nicholas Nethercote <nj...@ca...> wrote:
> I think there is a bug in helper_IN and helper_OUT. Both of them trash
> %eflags, because they contain 'cmp' instructions. But they don't preserve
> the flags with pushf/popf, the way that helper_fstsw_AX does, for example.
> I figure nobody's noticed this before because IN and OUT are so rare.
>
> Can somebody else confirm my thinking? I'll commit a fix if so.
I'd agree with you, it does look wrong as it stands.
Tom
--
Tom Hughes (th...@cy...)
Software Engineer, Cyberscience Corporation
http://www.cyberscience.com/
|