|
From: Jeremy F. <je...@go...> - 2002-10-03 04:35:57
|
Surely it should be: Index: include/vg_skin.h =================================================================== RCS file: /cvsroot/valgrind/valgrind/include/vg_skin.h,v retrieving revision 1.13 diff -u -r1.13 vg_skin.h --- include/vg_skin.h 2 Oct 2002 13:26:34 -0000 1.13 +++ include/vg_skin.h 3 Oct 2002 04:34:20 -0000 @@ -601,7 +603,7 @@ typedef UInt RRegSet; #define ALL_RREGS_DEAD 0 /* 0000...00b */ -#define ALL_RREGS_LIVE (1 << (VG_MAX_REALREGS-1)) /* 0011...11b */ +#define ALL_RREGS_LIVE ((1 << VG_MAX_REALREGS)-1) /* 0011...11b */ #define UNIT_RREGSET(rank) (1 << (rank)) #define IS_RREG_LIVE(rank,rregs_live) (rregs_live & UNIT_RREGSET(rank)) J |
|
From: Nicholas N. <nj...@ca...> - 2002-10-03 08:57:42
|
On 2 Oct 2002, Jeremy Fitzhardinge wrote: > Surely it should be: > > -#define ALL_RREGS_LIVE (1 << (VG_MAX_REALREGS-1)) /* 0011...11b */ > +#define ALL_RREGS_LIVE ((1 << VG_MAX_REALREGS)-1) /* 0011...11b */ Absolutely. I was wondering how anything worked at all with such an egregious error... turns out this value is only being used to initialise the reg liveness info, and is always overwritten by the liveness analysis. I just fixed it. Thanks. N |