|
From: James B. <ja...@ha...> - 2005-11-04 16:30:11
Attachments:
logfile.diff
|
Hi, Some time ago, the 'pid' part of the log files generated by Valgrind was removed (ie. the log file is now called 'logfile.1234' and not 'logfile.pid1234'). The accompanying blurb in the help text wasnt updated, which caused me a little confusion when running a script I wrote sometime ago (since it looked for files named 'logfile.pid*'). The attached patch cleans up the help text for this option (and a couple of other small bits and pieces whilst I'm at it). Cheers, James. James Begley -- Telephone: +354-575-2039. Marine Research Institute, Skulagata 4, P.O. Box 1390, 121 Reykjavik, Iceland. |
|
From: Nicholas N. <nj...@cs...> - 2005-11-04 16:46:30
|
On Fri, 4 Nov 2005, James Begley wrote: > Some time ago, the 'pid' part of the log files generated by Valgrind was > removed (ie. the log file is now called 'logfile.1234' and not > 'logfile.pid1234'). The accompanying blurb in the help text wasnt > updated, which caused me a little confusion when running a script I > wrote sometime ago (since it looked for files named 'logfile.pid*'). I'm wondering if the "pid" part should have been removed. Julian, did you intend this? I prefer it the new way (it matches Cachegrind and Massif better) but people don't like this sort of thing to change... Nick |
|
From: Tom H. <to...@co...> - 2005-11-04 16:50:10
|
In message <1131121791.22540.9.camel@hafnasandur>
James Begley <ja...@ha...> wrote:
> Some time ago, the 'pid' part of the log files generated by Valgrind was
> removed (ie. the log file is now called 'logfile.1234' and not
> 'logfile.pid1234'). The accompanying blurb in the help text wasnt
> updated, which caused me a little confusion when running a script I
> wrote sometime ago (since it looked for files named 'logfile.pid*').
>
> The attached patch cleans up the help text for this option (and a couple
> of other small bits and pieces whilst I'm at it).
Thanks for the patch. I have committed it.
Tom
--
Tom Hughes (to...@co...)
http://www.compton.nu/
|
|
From: James B. <ja...@ha...> - 2005-11-04 17:49:50
Attachments:
whitespace.diff
|
On Fri, 2005-11-04 at 10:59 -0600, Nicholas Nethercote wrote: > And the --alignment= whitespace change perhaps should be undone... it > looks ok with Memcheck but not with Massif. Hmmm ... so thats why the whitespace was screwed up for Memcheck :-) The attached patch contains a hack to get round this. The original function is left unchanged (and is called from within massif (and also helgrind when that is re-enabled)) and a new version with extra whitespace has been added, which is called from memcheck. With this patch applied, both "valgrind --tool=memcheck --help" and "valgrind --tool=massif --help" look OK. I realise this falls into the category of ugly-brute-force hack. Cheers, James. James Begley -- Telephone: +354-575-2039. Marine Research Institute, Skulagata 4, P.O. Box 1390, 121 Reykjavik, Iceland. |
|
From: Nicholas N. <nj...@cs...> - 2005-11-15 15:33:45
|
On Fri, 4 Nov 2005, James Begley wrote: > Hmmm ... so thats why the whitespace was screwed up for Memcheck :-) > > The attached patch contains a hack to get round this. The original > function is left unchanged (and is called from within massif (and also > helgrind when that is re-enabled)) and a new version with extra > whitespace has been added, which is called from memcheck. > > With this patch applied, both "valgrind --tool=memcheck --help" and > "valgrind --tool=massif --help" look OK. > > I realise this falls into the category of ugly-brute-force hack. Indeed :) I won't commit this, I don't think it's worth the effort. Thanks for your help. Take a look at http://www.valgrind.org/help/projects.html if you want to do any more stuff like this :) Nick |
|
From: Nicholas N. <nj...@cs...> - 2005-11-04 17:00:09
|
On Fri, 4 Nov 2005, Tom Hughes wrote: > Thanks for the patch. I have committed it. docs/xml/manual-core.xml also needs updating. And the --alignment= whitespace change perhaps should be undone... it looks ok with Memcheck but not with Massif. Nick |