|
From: Dirk M. <dm...@gm...> - 2005-06-26 22:15:09
Attachments:
valgrind.diff
|
Hi, another one from the "doesn't build" department: valgrind.vs is used for linking "stage2", which versions the exported symbols with VALGRIND_2_1. I see several problems with that: a) VALGRIND_2_1 wasn't updated to VALGRIND_2_4 b) stage2 is installed in the valgrind lib subdir, so it doesn't matter c) stage2 is a plain binary, nothing links against it Newer linkers correctly complain about c) and abort the build, because trying to version a binary simply doesn't make any sense. At least as far as I can imagine. So, can I just remove that? Dirk |
|
From: Nicholas N. <nj...@cs...> - 2005-06-26 22:53:15
|
On Mon, 27 Jun 2005, Dirk Mueller wrote: > another one from the "doesn't build" department: > > valgrind.vs is used for linking "stage2", which versions the exported symbols > with VALGRIND_2_1. > > I see several problems with that: > > a) VALGRIND_2_1 wasn't updated to VALGRIND_2_4 > b) stage2 is installed in the valgrind lib subdir, so it doesn't matter > c) stage2 is a plain binary, nothing links against it > > > Newer linkers correctly complain about c) and abort the build, because trying > to version a binary simply doesn't make any sense. At least as far as I can > imagine. > > So, can I just remove that? I thought the point of this file was to force any symbol that doesn't match any of the given prefixes (vgPlain_, etc) to be not exported. And the prefixes are out of date now. I'd be fine with it going. It's caused me troubles in the past by secretly hiding certain symbols that would normally have been public. It doesn't seem to add much. Jeremy, I believe you added it -- does it have some other purpose? N |
|
From: Dirk M. <dm...@gm...> - 2005-06-27 00:00:21
|
On Monday 27 June 2005 00:53, Nicholas Nethercote wrote: > I thought the point of this file was to force any symbol that doesn't > match any of the given prefixes (vgPlain_, etc) to be not exported. > And the prefixes are out of date now. it would be that way if there wasn't a version prefix (VALGRIND_2_1). with that, only the listed symbols are exported, but they're also versioned with the given tag. Dirk |
|
From: Nicholas N. <nj...@cs...> - 2005-06-30 04:40:51
|
On Sun, 26 Jun 2005, Nicholas Nethercote wrote: >> valgrind.vs is used for linking "stage2", which versions the exported >> ... >> So, can I just remove that? > > I'd be fine with it going. It's been a couple of days and no-one's objected -- I say do it! :) Thanks, Dirk. N |