|
From: Madhu M. K. <mm...@ya...> - 2005-05-24 09:29:13
|
Usages without verification of pointers.
--- valgrind.orig/coregrind/demangle/cp-demangle.c 2005-05-21
00:31:56.000000000 -0700
+++ valgrind/coregrind/demangle/cp-demangle.c 2005-05-21
00:44:17.000000000 -0700
@@ -413,9 +413,9 @@
int length;
{
string_list_t s = (string_list_t) malloc (sizeof (struct
string_list_def));
- s->caret_position = 0;
if (s == NULL)
return NULL;
+ s->caret_position = 0;
if (!dyn_string_init ((dyn_string_t) s, length))
return NULL;
return s;
@@ -3874,7 +3874,8 @@
if (next == cplus_demangled)
return cplus_demangled;
- dyn_string_append_cstr (demangled, next);
+ if (demangled != NULL)
+ dyn_string_append_cstr (demangled, next);
next = end;
}
}
Cheerio,
M
Madhu M Kurup /* Nemo Me Impune Lacessit */ mmk at yahoo-inc dt com
|
|
From: Nicholas N. <nj...@cs...> - 2005-05-25 21:32:20
|
On Tue, 24 May 2005, Madhu M. Kurup wrote: > Usages without verification of pointers. > > string_list_t s = (string_list_t) malloc (sizeof (struct > string_list_def)); > - s->caret_position = 0; > if (s == NULL) > return NULL; > + s->caret_position = 0; > return s; Committed, thanks. > @@ -3874,7 +3874,8 @@ > if (next == cplus_demangled) > return cplus_demangled; > > - dyn_string_append_cstr (demangled, next); > + if (demangled != NULL) > + dyn_string_append_cstr (demangled, next); > next = end; > } > } I'm reluctant to change this since I don't understand the code well enough. N |