|
From: Craig C. <cc...@us...> - 2005-05-02 16:54:54
Attachments:
small_reads.patch
|
Hi, This patch applies to Paul Mackerras' latest Valgrind PPC port (http://ozlabs.org/~paulus/valgrind-2.4.0-ppc-050407.tar.bz2). Small (1 or 2 bytes) invalid reads were not getting reported. See attached patch for a fix. Thanks, Craig -- Craig Chaney cc...@us... |
|
From: Nicholas N. <nj...@cs...> - 2005-05-02 18:31:49
|
On Mon, 2 May 2005, Craig Chaney wrote: > Small (1 or 2 bytes) invalid reads were not getting reported. See > attached patch for a fix. > > This patch adds logic to inet2name() to handle string conversion on big > endian platforms. We're trying to move away from compiler-defined symbols like __i386__ and __BIG_ENDIAN__, and defining our own equivalents. Julian just submitted some code to the Subversion repo that defines symbols like VGA_x86, VGO_linux and VGP_x86_linux. And we have VKI_LITTLE_ENDIAN in include/linux/vki.h. Since these patches are against 2.4, your approach is good enough for it, but I just thought I'd point this out for future reference. Also, when the PPC stuff gets merged into the Subversion repo hopefully we abstract out as many of these #ifdefs as possible into functions or macros. And keep up the good work, Craig! It's good to see people interested in the PPC port. N |