|
From: Bart V. A. <bar...@gm...> - 2006-11-26 18:05:49
Attachments:
pth_detached.diff.txt
|
Can anyone tell me where I can find instructions for writing regression tests ? I tried to add a regression test for detached POSIX threads, but "make -s regtest" tells me that it fails on stderr. All the test writes to stderr is the Valgrind banner however. -- Regards, Bart Van Assche. |
|
From: Julian S. <js...@ac...> - 2006-11-26 18:14:52
|
It's probably complaining that the .stderr.out (the actual stderr) does not match the .stderr.exp (the expected stderr). It will certainly complain if the .stderr.exp does not exist. What I do is create the .c file and .vgtest file edit Makefile.am ; rebuild right from ./autogen.sh so as to get up to date Makefiles make regtest (which dies on the test) copy .stderr.out to .stderr.exp (if it looks correct); ditto for .stdout.out/.stdout.exp J On Sunday 26 November 2006 18:05, Bart Van Assche wrote: > Can anyone tell me where I can find instructions for writing > regression tests ? I tried to add a regression test for detached POSIX > threads, but "make -s regtest" tells me that it fails on stderr. All > the test writes to stderr is the Valgrind banner however. |
|
From: Nicholas N. <nj...@cs...> - 2006-11-26 22:49:14
|
On Sun, 26 Nov 2006, Julian Seward wrote: > What I do is > > create the .c file and .vgtest file > > edit Makefile.am ; rebuild right from ./autogen.sh so as to get > up to date Makefiles > > make regtest (which dies on the test) > > copy .stderr.out to .stderr.exp (if it looks correct); ditto > for .stdout.out/.stdout.exp And .stdout.out can be omitted if it is empty. There's some documentation at the top of tests/vg_regtest.in, and also in docs/xml/manual-writing-tools.xml under "Regression tests". Nick |
|
From: Bart V. A. <bar...@gm...> - 2006-11-27 18:55:22
|
Thanks for all the help -- I have changed pth_detached.stderr.exp from an empty file into three blank lines, and my test now passes the regression tests. Can I submit this test now or should I wait until drd is finished ? This regression test (pth_detached.c) is not particularly useful for testin nulgrind in its current state, but is an essential regression test for nulgrind with the drd patch applied (because of the changes in coregrind/vg_preloaded.c). Bart Van Assche. On 11/26/06, Nicholas Nethercote <nj...@cs...> wrote: > On Sun, 26 Nov 2006, Julian Seward wrote: > > > What I do is > > > > create the .c file and .vgtest file > > > > edit Makefile.am ; rebuild right from ./autogen.sh so as to get > > up to date Makefiles > > > > make regtest (which dies on the test) > > > > copy .stderr.out to .stderr.exp (if it looks correct); ditto > > for .stdout.out/.stdout.exp > > And .stdout.out can be omitted if it is empty. > > There's some documentation at the top of tests/vg_regtest.in, and also in > docs/xml/manual-writing-tools.xml under "Regression tests". |
|
From: Nicholas N. <nj...@cs...> - 2006-11-27 22:14:13
|
On Mon, 27 Nov 2006, Bart Van Assche wrote: > Thanks for all the help -- I have changed pth_detached.stderr.exp from > an empty file into three blank lines, and my test now passes the > regression tests. Can I submit this test now or should I wait until > drd is finished ? This regression test (pth_detached.c) is not > particularly useful for testin nulgrind in its current state, but is > an essential regression test for nulgrind with the drd patch applied > (because of the changes in coregrind/vg_preloaded.c). Submit it now, I'll add it. Nick |
|
From: Bart V. A. <bar...@gm...> - 2006-11-28 19:05:51
Attachments:
pth_detached-patch.txt
|
I've attached a patch, but it has to be applied from within the none/tests directory -- I couldn't figure out which options to pass to patch in order to have a top-level "svn diff" patch applied successfully. The following commands worked for me: cd none/tests patch <~/pth_detached-patch.txt On 11/27/06, Nicholas Nethercote <nj...@cs...> wrote: > On Mon, 27 Nov 2006, Bart Van Assche wrote: > > > Thanks for all the help -- I have changed pth_detached.stderr.exp from > > an empty file into three blank lines, and my test now passes the > > regression tests. Can I submit this test now or should I wait until > > drd is finished ? This regression test (pth_detached.c) is not > > particularly useful for testin nulgrind in its current state, but is > > an essential regression test for nulgrind with the drd patch applied > > (because of the changes in coregrind/vg_preloaded.c). > > Submit it now, I'll add it. > > Nick |
|
From: Nicholas N. <nj...@cs...> - 2006-12-06 06:33:25
|
On Tue, 28 Nov 2006, Bart Van Assche wrote: > I've attached a patch, but it has to be applied from within the > none/tests directory -- I couldn't figure out which options to pass to > patch in order to have a top-level "svn diff" patch applied > successfully. The following commands worked for me: > cd none/tests > patch <~/pth_detached-patch.txt I've committed this. Sorry it took so long, I tested the patch but forgot to commit it after I did so! Nick |