|
From: Bryan M. <om...@br...> - 2006-07-13 21:34:59
|
Dear Valgrind Developers / Core Team, I have been driven mad by a couple of leak reports in a system library - I really wasn't sure if I had messed up Omega (again) so I got the sources, built unoptimised debug versions of the libraries, installed them and ran a small program to try and trip the leaks. It did and whats more, Memcheck agrees on the amount leaked and the allocator location so it looks like Omega was actually OK (I get a bunch of circular reference leaks as well). I had a look at the source but there is no way I can spend enough time to work out why its leaking and proffer a patch. What would be a good way to approach the project team as "your stuff leaks here - my experimental tool says so (and so does this one)" is probably not going to make me any friends... Finally, how do I go about requesting a link to Omega be added to your patches page and what criteria would I have to meet? thanks in advance, Bryan "Brain Murders" Meredith |
|
From: Nicholas N. <nj...@cs...> - 2006-07-14 01:12:39
|
On Thu, 13 Jul 2006, Bryan Meredith wrote: > What would be a good way to approach the project team as "your stuff > leaks here - my experimental tool says so (and so does this one)" is > probably not going to make me any friends... I don't think there's harm in telling people. It's just a bug report, people should be happy to get them, especially if it has good info on what the root cause is. You could say "your program has a leak here, and by the way I used my tool Omega to automatically find it". > Finally, how do I go about requesting a link to Omega be added to your > patches page and what criteria would I have to meet? There's no real criteria... I'm happy to add something to the Variants/Patches page. Can you give me a one sentence description and a URL to link to? Nick |
|
From: Bryan M. <om...@br...> - 2006-07-27 23:15:22
|
Nick, nearly forgot (been a little busy of late) Would you mind adding something along the lines of: Omega - an instant memory leak detector tool designed to give the location that a leak occurs, as it occurs. http://www.brainmurders.eclipse.co.uk/omega.html Cheers, Bryan "Brain Murders" Meredith Nicholas Nethercote wrote: > On Thu, 13 Jul 2006, Bryan Meredith wrote: > >> What would be a good way to approach the project team as "your stuff >> leaks here - my experimental tool says so (and so does this one)" is >> probably not going to make me any friends... > > I don't think there's harm in telling people. It's just a bug report, > people should be happy to get them, especially if it has good info on what > the root cause is. You could say "your program has a leak here, and by the > way I used my tool Omega to automatically find it". > >> Finally, how do I go about requesting a link to Omega be added to your >> patches page and what criteria would I have to meet? > > There's no real criteria... I'm happy to add something to the > Variants/Patches page. Can you give me a one sentence description and a > URL to link to? > > Nick > > > ------------------------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > _______________________________________________ > Valgrind-developers mailing list > Val...@li... > https://lists.sourceforge.net/lists/listinfo/valgrind-developers > |
Bryan Meredith wrote: > What would be a good way to approach the project team as "your stuff > leaks here - my experimental tool says so (and so does this one)" is > probably not going to make me any friends... Perhaps they would be convinced by a simple test program (preferably short, too) that contains a loop which triggers the leak over and over. Use the "VIRT" column of the output from /usr/bin/top , or the "SZ" column of the output from "ps -l" to show that the process size is increasing when it should not. Then give them the patch that fixes the leak, and run the test program again, observing no increase in size. Wait until they ask, "Neat. How did you find the leak?" -- |