|
From: Paralkar Anmol-B. <B0...@fr...> - 2013-09-05 01:21:48
Attachments:
mulldo.VEX.patch
mulldo.valgrind.patch
|
Hello, The attached patches contain a fix for computing the overflow and test-cases for the Power ISA 2.06 instructions: mulldo/mulldo. The existing overflow detection in VEX/priv/guest_ppc_toIR.c/set_XER_OV_64() under the case PPCG_FLAG_OP_MULLW: does not apply to the mulldo[.]? as we need to detect overflow when performing a Multiply Low Doubleword (not Multiply Low Word). Hence, we added a new enumeration value PPCG_FLAG_OP_MULLD in VEX/priv/guest_ppc_defs.h and a corresponding new case under which the computation for detecting overflow for mulldo/mulldo. is added in set_XER_OV_64(). The tests have been added to: none/tests/ppc32/jm-insns.c none/tests/ppc64/jm-int.stdout.exp matches the stdout content when: none/tests/ppc64> ./jm-insns -i - is run directly on the machine. I have verified that there are no regressions relative to the pristine trunk by diffing the logs generated when: > make regtest All testing was done on an IBM POWER7 system running Linux 3.1.5-6.fc16.ppc64 on Valgrind trunk Rev: 13532 and VEX Rev: 2750. Kindly let me know of any suggestions for improvement and I will be happy to incorporate them and re-spin the patches as necessary for submission, thank you. Regards, Anmol P. Paralkar an...@fr... |