|
From: Petar J. <mip...@gm...> - 2013-07-03 02:00:26
|
On Tue, Jul 2, 2013 at 9:30 PM, Zahid Anwar <zah...@se...>wrote: > Hi everyone, > > We would like to contribute the following eight instructions to Valgrind, > required to support the MIPS OCTEON platform. We have prepared a patch for > valgrind release 3.9.0 r13426 that modifies VEX guest_mips_toIR.c > > We seek guidance on what steps are involved in order for us to apply this > patch to the main-stream? > > The README and patch are attached. > > Instructions > - CINS > - CINS32 > - SNE > - SEQI > - SNEI > - EXTS > - EXTS32 > - DMULT > > Regards, > Zahid > Hello Zahid, first of all, thank you for sending the patches. Before we go into review, can you do a few steps first - these are: 1. make sure you update your patch with the applicable set of tests for each of the instructions. Look into /none/tests/mips64 for examples and desired level of tests per instruction. 2. update your patch so the code is active for Cavium boards only. Look how archinfo->hwcaps is used. Look for VEX_PRID_COMP_BROADCOM to see kind of changes that are needed. 3. open up a new bug at Bugzilla at https://bugs.kde.org/ so we can track this there. Thank you. Petar |