|
From: Rhys K. <rhy...@gm...> - 2015-11-03 05:46:24
|
Amend vassert() checking of the hwcaps_host variable to correctly handle
all cases.
Reported by Coverity #1308873 Logical vs. bitwise operator.
Index: priv/host_mips_isel.c
===================================================================
--- priv/host_mips_isel.c (revision 3201)
+++ priv/host_mips_isel.c (working copy)
@@ -4173,7 +4173,7 @@
vassert(arch_host == VexArchMIPS32 || arch_host == VexArchMIPS64);
vassert(VEX_PRID_COMP_MIPS == hwcaps_host
|| VEX_PRID_COMP_BROADCOM == hwcaps_host
- || VEX_PRID_COMP_NETLOGIC);
+ || VEX_PRID_COMP_NETLOGIC == hwcaps_host);
/* Check that the host's endianness is as expected. */
vassert(archinfo_host->endness == VexEndnessLE
|
|
From: Petar J. <mip...@gm...> - 2015-11-13 15:49:36
|
Fixed in VEX r3203. Thanks for the report. Regards, Petar On Tue, Nov 3, 2015 at 6:46 AM, Rhys Kidd <rhy...@gm...> wrote: > Amend vassert() checking of the hwcaps_host variable to correctly handle > all cases. > > Reported by Coverity #1308873 Logical vs. bitwise operator. > > Index: priv/host_mips_isel.c > =================================================================== > --- priv/host_mips_isel.c (revision 3201) > +++ priv/host_mips_isel.c (working copy) > @@ -4173,7 +4173,7 @@ > vassert(arch_host == VexArchMIPS32 || arch_host == VexArchMIPS64); > vassert(VEX_PRID_COMP_MIPS == hwcaps_host > || VEX_PRID_COMP_BROADCOM == hwcaps_host > - || VEX_PRID_COMP_NETLOGIC); > + || VEX_PRID_COMP_NETLOGIC == hwcaps_host); > > /* Check that the host's endianness is as expected. */ > vassert(archinfo_host->endness == VexEndnessLE > > > ------------------------------------------------------------------------------ > > _______________________________________________ > Valgrind-developers mailing list > Val...@li... > https://lists.sourceforge.net/lists/listinfo/valgrind-developers > > |