|
From: Julian S. <js...@ac...> - 2017-07-06 12:52:11
|
Hi Tanya, Sorry for the slow reply. I was OOo last week. > We have implemented a number of AVX-512 instructions in Valgrind core. > NAS IS benchmark, compiled with AVX-512, runs correctly under Nulgrind. > Tests for the implemented AVX-512 instructions (similar to the tests in > ./none/tests/amd64/avx2-1.c) also work correctly. Good. > 1. What has higher priority, Memcheck correctness or full instruction set coverage? Instruction set coverage. Getting Memcheck to handle new IRs is much easier than adding new insn support. > 2. When should we start submitting patches: when everything is added and > tested on more benchmarks, or earlier, in order to review a work-in- > progress? Earlier is better. Even if they don't get landed immediately, they can be looked at by others. In particular I'd like to see what new IROps you had to add. Do you have a bug report (bugs.kde.org) tracking this, to which you can attach the patches? That is the usual way of doing reviews. J |