|
From: Florian K. <fl...@ei...> - 2015-08-08 21:47:15
|
I've fixed what gcc -Wformat-signedness pointed out on amd64, x86, and s390. On the ppc machine I have access to there was no suitable gcc and attempting to build 5.1 failed with some strange error message I don't recall. Carl, perhaps you have a suitable machine + compiler handy? I made obvious fixes in platform-specific code which I could not compile, but no guarantees that everything is fixed. This holds in particular for Darwin and Solaris. Hopefully, I did not introduce syntax errors. Apologies in advance. configure.ac was changed to detect whether the compiler supports -Wformat-signedness but the test is disabled, because it is not clear that we get the code cleaned up for all platforms in time for the release. So... if you want to play with this you need to enable this line # AC_GCC_WARNING_SUBST([format-signedness], [FLAG_W_FORMAT_SIGNEDNESS]) Cheers, Florian |
|
From: Ivo R. <ivo...@gm...> - 2015-08-08 22:10:24
|
2015-08-08 23:47 GMT+02:00 Florian Krohm <fl...@ei...>: > Hopefully, I did not introduce syntax errors. Apologies in advance. > configure.ac was changed to detect whether the compiler supports > -Wformat-signedness but the test is disabled, because it is not clear > that we get the code cleaned up for all platforms in time for the release. > So... if you want to play with this you need to enable this line > > # AC_GCC_WARNING_SUBST([format-signedness], [FLAG_W_FORMAT_SIGNEDNESS]) > Thank you for all the formatting fixes! These were numerous to find and fix. Good work here. However with the latest greatest changes, the compilation fails with: gcc: error: @FLAG_W_FORMAT_SIGNEDNESS@: No such file or directory I believe this is because expansion of @FLAG_W_FORMAT_SIGNEDNESS@ is commented out in configure.ac but @FLAG_W_FORMAT_SIGNEDNESS@ is still present in Makefile.all.am. Either it needs to unconditionally expand to something empty or it needs to be deleted from Makefile.all.am. I. |
|
From: Rhys K. <rhy...@gm...> - 2015-08-08 22:23:01
|
Hello Florian, Thank you for all these signedness fixes. I know how unfun it is to find and resolve them, so thank you. Darwin does also experience the new compile error at present: clang: error: no such file or directory: '@FLAG_W_FORMAT_SIGNEDNESS@' Uncommenting the below line in configure.ac did not lead to a snowstorm of compiler warnings, so for Darwin I'd be happy to see it enabled (per what is the the proper fix here). # AC_GCC_WARNING_SUBST([format-signedness], [FLAG_W_FORMAT_SIGNEDNESS]) Regards, Rhys On 9 August 2015 at 08:10, Ivo Raisr <ivo...@gm...> wrote: > > > 2015-08-08 23:47 GMT+02:00 Florian Krohm <fl...@ei...>: > >> Hopefully, I did not introduce syntax errors. Apologies in advance. >> configure.ac was changed to detect whether the compiler supports >> -Wformat-signedness but the test is disabled, because it is not clear >> that we get the code cleaned up for all platforms in time for the release. >> So... if you want to play with this you need to enable this line >> >> # AC_GCC_WARNING_SUBST([format-signedness], [FLAG_W_FORMAT_SIGNEDNESS]) >> > > > Thank you for all the formatting fixes! > These were numerous to find and fix. Good work here. > > However with the latest greatest changes, the compilation fails with: > gcc: error: @FLAG_W_FORMAT_SIGNEDNESS@: No such file or directory > > I believe this is because expansion of @FLAG_W_FORMAT_SIGNEDNESS@ > is commented out in configure.ac but @FLAG_W_FORMAT_SIGNEDNESS@ > is still present in Makefile.all.am. Either it needs to unconditionally > expand > to something empty or it needs to be deleted from Makefile.all.am. > > I. > > > ------------------------------------------------------------------------------ > > _______________________________________________ > Valgrind-developers mailing list > Val...@li... > https://lists.sourceforge.net/lists/listinfo/valgrind-developers > > |
|
From: Florian K. <fl...@ei...> - 2015-08-09 08:26:55
|
Hi Rhys On 09.08.2015 00:22, Rhys Kidd wrote: > > Uncommenting the below line in configure.ac did not lead to a snowstorm of > compiler warnings, so for Darwin I'd be happy to see it enabled (per what > is the the proper fix here). Careful.... Are you sure that your compiler understands -Wformat-signedness ? Because, if it does not, -Wformat-signedness will not be used when compiling (obviously). Hence, you don't see any warnings :) clang-3.6.0 and earlier do not support -Wformat-signedness... Not sure about newer releases. Florian |
|
From: Florian K. <fl...@ei...> - 2015-08-09 08:19:07
|
On 09.08.2015 00:10, Ivo Raisr wrote: > > However with the latest greatest changes, the compilation fails with: > gcc: error: @FLAG_W_FORMAT_SIGNEDNESS@: No such file or directory > Sorry for the breakage. I fixed it in r15511. Florian |