|
From: <sv...@va...> - 2009-07-21 14:56:04
|
Author: bart Date: 2009-07-21 15:55:52 +0100 (Tue, 21 Jul 2009) New Revision: 10504 Log: Added --auto-run-dsymutil=yes to --var-info=yes. Modified: trunk/drd/tests/annotate_ignore_read.vgtest trunk/drd/tests/annotate_order_1.vgtest trunk/drd/tests/annotate_order_2.vgtest trunk/drd/tests/annotate_order_3.vgtest trunk/drd/tests/annotate_rwlock.vgtest trunk/drd/tests/annotate_spinlock.vgtest trunk/drd/tests/annotate_trace_memory.vgtest trunk/drd/tests/atomic_var.vgtest trunk/drd/tests/boost_thread.vgtest trunk/drd/tests/fp_race.vgtest trunk/drd/tests/hg03_inherit.vgtest trunk/drd/tests/hg04_race.vgtest trunk/drd/tests/hg05_race2.vgtest trunk/drd/tests/linuxthreads_det.vgtest trunk/drd/tests/omp_matinv.vgtest trunk/drd/tests/omp_matinv_racy.vgtest trunk/drd/tests/omp_prime_racy.vgtest trunk/drd/tests/omp_printf.vgtest trunk/drd/tests/pth_cancel_locked.vgtest trunk/drd/tests/pth_cleanup_handler.vgtest trunk/drd/tests/pth_create_glibc_2_0.vgtest trunk/drd/tests/pth_detached2.vgtest trunk/drd/tests/pth_mutex_reinit.vgtest trunk/drd/tests/pth_process_shared_mutex.vgtest trunk/drd/tests/pth_spinlock.vgtest trunk/drd/tests/recursive_mutex.vgtest trunk/drd/tests/rwlock_race.vgtest trunk/drd/tests/sem_as_mutex.vgtest trunk/drd/tests/sem_as_mutex2.vgtest trunk/drd/tests/sem_as_mutex3.vgtest trunk/drd/tests/tc01_simple_race.vgtest trunk/drd/tests/tc16_byterace.vgtest trunk/drd/tests/tc19_shadowmem.vgtest trunk/drd/tests/tc20_verifywrap.vgtest trunk/drd/tests/tc20_verifywrap2.vgtest trunk/drd/tests/tc24_nonzero_sem.vgtest trunk/drd/tests/thread_name.vgtest Modified: trunk/drd/tests/annotate_ignore_read.vgtest =================================================================== --- trunk/drd/tests/annotate_ignore_read.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/annotate_ignore_read.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,5 +1,5 @@ prereq: test -e tsan_unittest && ./supported_libpthread -vgopts: --var-info=yes --check-stack-var=yes --show-confl-seg=no +vgopts: --var-info=yes --auto-run-dsymutil=yes --check-stack-var=yes --show-confl-seg=no prog: tsan_unittest args: 69 stderr_filter: filter_stderr_and_thread_no Modified: trunk/drd/tests/annotate_order_1.vgtest =================================================================== --- trunk/drd/tests/annotate_order_1.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/annotate_order_1.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,5 +1,5 @@ prereq: test -e tsan_unittest && ./supported_libpthread -vgopts: --var-info=yes --check-stack-var=yes --show-confl-seg=no +vgopts: --var-info=yes --auto-run-dsymutil=yes --check-stack-var=yes --show-confl-seg=no prog: tsan_unittest args: 3 stderr_filter: filter_stderr_and_thread_no Modified: trunk/drd/tests/annotate_order_2.vgtest =================================================================== --- trunk/drd/tests/annotate_order_2.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/annotate_order_2.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,5 +1,5 @@ prereq: test -e tsan_unittest && ./supported_libpthread -vgopts: --var-info=yes --check-stack-var=yes --show-confl-seg=no +vgopts: --var-info=yes --auto-run-dsymutil=yes --check-stack-var=yes --show-confl-seg=no prog: tsan_unittest args: 30 stderr_filter: filter_stderr_and_thread_no Modified: trunk/drd/tests/annotate_order_3.vgtest =================================================================== --- trunk/drd/tests/annotate_order_3.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/annotate_order_3.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,5 +1,5 @@ prereq: test -e tsan_unittest && ./supported_libpthread -vgopts: --var-info=yes --check-stack-var=yes --show-confl-seg=no +vgopts: --var-info=yes --auto-run-dsymutil=yes --check-stack-var=yes --show-confl-seg=no prog: tsan_unittest args: 31 stderr_filter: filter_stderr_and_thread_no Modified: trunk/drd/tests/annotate_rwlock.vgtest =================================================================== --- trunk/drd/tests/annotate_rwlock.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/annotate_rwlock.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,4 +1,4 @@ prereq: test -e annotate_rwlock && ./supported_libpthread -vgopts: --var-info=yes --check-stack-var=yes --show-confl-seg=no +vgopts: --var-info=yes --auto-run-dsymutil=yes --check-stack-var=yes --show-confl-seg=no prog: annotate_rwlock stderr_filter: filter_stderr_and_thread_no Modified: trunk/drd/tests/annotate_spinlock.vgtest =================================================================== --- trunk/drd/tests/annotate_spinlock.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/annotate_spinlock.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,5 +1,5 @@ prereq: test -e tsan_unittest && ./supported_libpthread -vgopts: --var-info=yes --check-stack-var=yes --show-confl-seg=no +vgopts: --var-info=yes --auto-run-dsymutil=yes --check-stack-var=yes --show-confl-seg=no prog: tsan_unittest args: 27 stderr_filter: filter_stderr_and_thread_no Modified: trunk/drd/tests/annotate_trace_memory.vgtest =================================================================== --- trunk/drd/tests/annotate_trace_memory.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/annotate_trace_memory.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,5 +1,5 @@ prereq: test -e tsan_unittest && ./supported_libpthread -vgopts: --var-info=yes --check-stack-var=yes --show-confl-seg=no --num-callers=2 +vgopts: --var-info=yes --auto-run-dsymutil=yes --check-stack-var=yes --show-confl-seg=no --num-callers=2 prog: tsan_unittest args: 1 stderr_filter: filter_stderr_and_thread_no Modified: trunk/drd/tests/atomic_var.vgtest =================================================================== --- trunk/drd/tests/atomic_var.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/atomic_var.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,4 +1,4 @@ prereq: test -e atomic_var && ./supported_libpthread -vgopts: --var-info=yes --check-stack-var=yes --show-confl-seg=no +vgopts: --var-info=yes --auto-run-dsymutil=yes --check-stack-var=yes --show-confl-seg=no prog: atomic_var stderr_filter: filter_stderr_and_thread_no Modified: trunk/drd/tests/boost_thread.vgtest =================================================================== --- trunk/drd/tests/boost_thread.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/boost_thread.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,3 +1,3 @@ prereq: test -e boost_thread -vgopts: --var-info=yes +vgopts: --var-info=yes --auto-run-dsymutil=yes prog: boost_thread Modified: trunk/drd/tests/fp_race.vgtest =================================================================== --- trunk/drd/tests/fp_race.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/fp_race.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,3 +1,3 @@ prereq: ./supported_libpthread -vgopts: --var-info=yes +vgopts: --var-info=yes --auto-run-dsymutil=yes prog: fp_race Modified: trunk/drd/tests/hg03_inherit.vgtest =================================================================== --- trunk/drd/tests/hg03_inherit.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/hg03_inherit.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,3 +1,3 @@ prereq: ./supported_libpthread -vgopts: --show-confl-seg=no --var-info=yes +vgopts: --show-confl-seg=no --var-info=yes --auto-run-dsymutil=yes prog: ../../helgrind/tests/hg03_inherit Modified: trunk/drd/tests/hg04_race.vgtest =================================================================== --- trunk/drd/tests/hg04_race.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/hg04_race.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,3 +1,3 @@ prereq: ./supported_libpthread -vgopts: --var-info=yes +vgopts: --var-info=yes --auto-run-dsymutil=yes prog: ../../helgrind/tests/hg04_race Modified: trunk/drd/tests/hg05_race2.vgtest =================================================================== --- trunk/drd/tests/hg05_race2.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/hg05_race2.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,3 +1,3 @@ prereq: ./supported_libpthread -vgopts: --var-info=yes --check-stack-var=yes +vgopts: --var-info=yes --auto-run-dsymutil=yes --check-stack-var=yes prog: ../../helgrind/tests/hg05_race2 Modified: trunk/drd/tests/linuxthreads_det.vgtest =================================================================== --- trunk/drd/tests/linuxthreads_det.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/linuxthreads_det.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,2 +1,2 @@ prog: linuxthreads_det -vgopts: --var-info=yes +vgopts: --var-info=yes --auto-run-dsymutil=yes Modified: trunk/drd/tests/omp_matinv.vgtest =================================================================== --- trunk/drd/tests/omp_matinv.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/omp_matinv.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,4 +1,4 @@ prereq: ./run_openmp_test ./omp_matinv prog: omp_matinv -vgopts: --check-stack-var=yes --var-info=yes +vgopts: --check-stack-var=yes --var-info=yes --auto-run-dsymutil=yes args: 30 -t 15 -q Modified: trunk/drd/tests/omp_matinv_racy.vgtest =================================================================== --- trunk/drd/tests/omp_matinv_racy.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/omp_matinv_racy.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,5 +1,5 @@ prereq: ./run_openmp_test ./omp_matinv prog: omp_matinv -vgopts: --check-stack-var=yes --var-info=yes +vgopts: --check-stack-var=yes --var-info=yes --auto-run-dsymutil=yes args: 3 -t 2 -q -r stderr_filter: filter_error_summary Modified: trunk/drd/tests/omp_prime_racy.vgtest =================================================================== --- trunk/drd/tests/omp_prime_racy.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/omp_prime_racy.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,5 +1,5 @@ prereq: ./run_openmp_test ./omp_prime prog: omp_prime -vgopts: --check-stack-var=yes --var-info=yes +vgopts: --check-stack-var=yes --var-info=yes --auto-run-dsymutil=yes args: 4 -q stderr_filter: filter_error_summary Modified: trunk/drd/tests/omp_printf.vgtest =================================================================== --- trunk/drd/tests/omp_printf.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/omp_printf.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,5 +1,5 @@ prereq: ./run_openmp_test ./omp_printf prog: omp_printf -vgopts: --check-stack-var=yes --var-info=yes +vgopts: --check-stack-var=yes --var-info=yes --auto-run-dsymutil=yes args: -q stderr_filter: filter_error_summary Modified: trunk/drd/tests/pth_cancel_locked.vgtest =================================================================== --- trunk/drd/tests/pth_cancel_locked.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/pth_cancel_locked.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,3 +1,3 @@ prereq: ./supported_libpthread -vgopts: --var-info=yes --check-stack-var=yes +vgopts: --var-info=yes --auto-run-dsymutil=yes --check-stack-var=yes prog: pth_cancel_locked Modified: trunk/drd/tests/pth_cleanup_handler.vgtest =================================================================== --- trunk/drd/tests/pth_cleanup_handler.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/pth_cleanup_handler.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,3 +1,3 @@ prereq: test -e pth_cleanup_handler && ./supported_libpthread -vgopts: --var-info=yes --check-stack-var=yes +vgopts: --var-info=yes --auto-run-dsymutil=yes --check-stack-var=yes prog: pth_cleanup_handler Modified: trunk/drd/tests/pth_create_glibc_2_0.vgtest =================================================================== --- trunk/drd/tests/pth_create_glibc_2_0.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/pth_create_glibc_2_0.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,3 +1,3 @@ prereq: test -e pth_create_glibc_2_0 && ./supported_libpthread -vgopts: --var-info=yes --check-stack-var=yes +vgopts: --var-info=yes --auto-run-dsymutil=yes --check-stack-var=yes prog: pth_create_glibc_2_0 Modified: trunk/drd/tests/pth_detached2.vgtest =================================================================== --- trunk/drd/tests/pth_detached2.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/pth_detached2.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,4 +1,4 @@ prereq: ./supported_libpthread -vgopts: --var-info=yes +vgopts: --var-info=yes --auto-run-dsymutil=yes prog: pth_detached args: 10 10 Modified: trunk/drd/tests/pth_mutex_reinit.vgtest =================================================================== --- trunk/drd/tests/pth_mutex_reinit.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/pth_mutex_reinit.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,3 +1,3 @@ prereq: test -e pth_mutex_reinit && ./supported_libpthread -vgopts: --var-info=yes --check-stack-var=yes +vgopts: --var-info=yes --auto-run-dsymutil=yes --check-stack-var=yes prog: pth_mutex_reinit Modified: trunk/drd/tests/pth_process_shared_mutex.vgtest =================================================================== --- trunk/drd/tests/pth_process_shared_mutex.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/pth_process_shared_mutex.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,3 +1,3 @@ prereq: ./supported_libpthread prog: pth_process_shared_mutex -vgopts: --var-info=yes --check-stack-var=yes +vgopts: --var-info=yes --auto-run-dsymutil=yes --check-stack-var=yes Modified: trunk/drd/tests/pth_spinlock.vgtest =================================================================== --- trunk/drd/tests/pth_spinlock.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/pth_spinlock.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,3 +1,3 @@ prereq: test -e pth_spinlock && ./supported_libpthread -vgopts: --var-info=yes --check-stack-var=yes +vgopts: --var-info=yes --auto-run-dsymutil=yes --check-stack-var=yes prog: pth_spinlock Modified: trunk/drd/tests/recursive_mutex.vgtest =================================================================== --- trunk/drd/tests/recursive_mutex.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/recursive_mutex.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,4 +1,4 @@ prereq: ./supported_libpthread -vgopts: --check-stack-var=yes --var-info=yes +vgopts: --check-stack-var=yes --var-info=yes --auto-run-dsymutil=yes prog: recursive_mutex stderr_filter: filter_stderr_and_thread_no Modified: trunk/drd/tests/rwlock_race.vgtest =================================================================== --- trunk/drd/tests/rwlock_race.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/rwlock_race.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,3 +1,3 @@ prereq: ./supported_libpthread -vgopts: --var-info=yes +vgopts: --var-info=yes --auto-run-dsymutil=yes prog: rwlock_race Modified: trunk/drd/tests/sem_as_mutex.vgtest =================================================================== --- trunk/drd/tests/sem_as_mutex.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/sem_as_mutex.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,3 +1,3 @@ prereq: ./supported_libpthread -vgopts: --check-stack-var=yes --var-info=yes +vgopts: --check-stack-var=yes --var-info=yes --auto-run-dsymutil=yes prog: sem_as_mutex Modified: trunk/drd/tests/sem_as_mutex2.vgtest =================================================================== --- trunk/drd/tests/sem_as_mutex2.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/sem_as_mutex2.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,4 +1,4 @@ prereq: ./supported_libpthread -vgopts: --check-stack-var=yes --var-info=yes +vgopts: --check-stack-var=yes --var-info=yes --auto-run-dsymutil=yes prog: sem_as_mutex args: -m Modified: trunk/drd/tests/sem_as_mutex3.vgtest =================================================================== --- trunk/drd/tests/sem_as_mutex3.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/sem_as_mutex3.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,3 +1,3 @@ prereq: ./supported_libpthread -vgopts: --check-stack-var=yes --first-race-only=yes --var-info=yes +vgopts: --check-stack-var=yes --first-race-only=yes --var-info=yes --auto-run-dsymutil=yes prog: sem_as_mutex Modified: trunk/drd/tests/tc01_simple_race.vgtest =================================================================== --- trunk/drd/tests/tc01_simple_race.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/tc01_simple_race.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,3 +1,3 @@ prereq: ./supported_libpthread -vgopts: --var-info=yes +vgopts: --var-info=yes --auto-run-dsymutil=yes prog: ../../helgrind/tests/tc01_simple_race Modified: trunk/drd/tests/tc16_byterace.vgtest =================================================================== --- trunk/drd/tests/tc16_byterace.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/tc16_byterace.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,3 +1,3 @@ prereq: ./supported_libpthread -vgopts: --var-info=yes +vgopts: --var-info=yes --auto-run-dsymutil=yes prog: ../../helgrind/tests/tc16_byterace Modified: trunk/drd/tests/tc19_shadowmem.vgtest =================================================================== --- trunk/drd/tests/tc19_shadowmem.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/tc19_shadowmem.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,4 +1,4 @@ prereq: ./supported_libpthread prog: ../../helgrind/tests/tc19_shadowmem -vgopts: --error-limit=no --var-info=yes --show-confl-seg=no +vgopts: --error-limit=no --var-info=yes --auto-run-dsymutil=yes --show-confl-seg=no stderr_filter: filter_stderr_and_thread_no Modified: trunk/drd/tests/tc20_verifywrap.vgtest =================================================================== --- trunk/drd/tests/tc20_verifywrap.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/tc20_verifywrap.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,3 +1,3 @@ prereq: test -e ../../helgrind/tests/tc20_verifywrap && ./supported_libpthread -vgopts: --var-info=yes --check-stack-var=yes +vgopts: --var-info=yes --auto-run-dsymutil=yes --check-stack-var=yes prog: ../../helgrind/tests/tc20_verifywrap Modified: trunk/drd/tests/tc20_verifywrap2.vgtest =================================================================== --- trunk/drd/tests/tc20_verifywrap2.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/tc20_verifywrap2.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,3 +1,3 @@ prereq: ./supported_libpthread -vgopts: --trace-mutex=yes --trace-cond=yes --trace-semaphore=yes --var-info=yes --check-stack-var=yes +vgopts: --trace-mutex=yes --trace-cond=yes --trace-semaphore=yes --var-info=yes --auto-run-dsymutil=yes --check-stack-var=yes prog: ../../helgrind/tests/tc20_verifywrap Modified: trunk/drd/tests/tc24_nonzero_sem.vgtest =================================================================== --- trunk/drd/tests/tc24_nonzero_sem.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/tc24_nonzero_sem.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,3 +1,3 @@ prereq: ./supported_libpthread prog: ../../helgrind/tests/tc24_nonzero_sem -vgopts: --var-info=yes +vgopts: --var-info=yes --auto-run-dsymutil=yes Modified: trunk/drd/tests/thread_name.vgtest =================================================================== --- trunk/drd/tests/thread_name.vgtest 2009-07-21 12:39:25 UTC (rev 10503) +++ trunk/drd/tests/thread_name.vgtest 2009-07-21 14:55:52 UTC (rev 10504) @@ -1,3 +1,3 @@ prereq: test -e thread_name && ./supported_libpthread -vgopts: --var-info=yes --check-stack-var=yes +vgopts: --var-info=yes --auto-run-dsymutil=yes --check-stack-var=yes prog: thread_name |
|
From: Nicholas N. <n.n...@gm...> - 2009-07-22 01:46:36
|
On Wed, Jul 22, 2009 at 12:55 AM, <sv...@va...> wrote: > Author: bart > Date: 2009-07-21 15:55:52 +0100 (Tue, 21 Jul 2009) > New Revision: 10504 > > Log: > Added --auto-run-dsymutil=yes to --var-info=yes. I don't think this is necessary. The .dSYM/ directory is built for all regtests by default. Also, how is DRD's --var-info=yes different to the core's --read-var-info=yes? It seems like DRD should just use --read-var-info=yes the way Memcheck and Helgrind do. Nick |
|
From: Bart V. A. <bar...@gm...> - 2009-07-22 07:32:37
|
On Wed, Jul 22, 2009 at 3:46 AM, Nicholas Nethercote <n.n...@gm...> wrote: > > On Wed, Jul 22, 2009 at 12:55 AM, <sv...@va...> wrote: > > Author: bart > > Date: 2009-07-21 15:55:52 +0100 (Tue, 21 Jul 2009) > > New Revision: 10504 > > > > Log: > > Added --auto-run-dsymutil=yes to --var-info=yes. > > I don't think this is necessary. The .dSYM/ directory is built for > all regtests by default. There are two reasons why I added --auto-run-dsymutil=yes: * At least on the system I ran my tests on, the .dSYM directory was not built by default. * The message that suggests to add --auto-run-dsymutil=yes is hard to filter away from the regression test output because it consists of two lines of output. > Also, how is DRD's --var-info=yes different to the core's > --read-var-info=yes? It seems like DRD should just use > --read-var-info=yes the way Memcheck and Helgrind do. If I remember correctly, --var-info was added to DRD before --read-var-info was added to Memcheck or Helgrind. I have renamed the DRD option --var-info to --read-var-info and left --var-info as an undocumented option in DRD. Bart. |
|
From: Julian S. <js...@ac...> - 2009-07-22 08:07:32
|
> > Also, how is DRD's --var-info=yes different to the core's > > --read-var-info=yes? It seems like DRD should just use > > --read-var-info=yes the way Memcheck and Helgrind do. > > If I remember correctly, --var-info was added to DRD before > --read-var-info was added to Memcheck or Helgrind. I have renamed the > DRD option --var-info to --read-var-info and left --var-info as an > undocumented option in DRD. --read-var-info is a flag handled by the core, and applies to all tools. It tells the debuginfo reader what to do. It's not handled separately by all tools. The question of whether the tools can actually make use of that extra info is a different question. So I think DRD shouldn't handle this flag at all. J |
|
From: Nicholas N. <n.n...@gm...> - 2009-07-22 08:10:22
|
On Wed, Jul 22, 2009 at 5:32 PM, Bart Van Assche<bar...@gm...> wrote: > > There are two reasons why I added --auto-run-dsymutil=yes: > * At least on the system I ran my tests on, the .dSYM directory was > not built by default. > * The message that suggests to add --auto-run-dsymutil=yes is hard to > filter away from the regression test output because it consists of two > lines of output. I'd prefer to work out why the dSYMs aren't being built for your system. It's an old one -- 9.2.0 or something like that? >> Also, how is DRD's --var-info=yes different to the core's >> --read-var-info=yes? It seems like DRD should just use >> --read-var-info=yes the way Memcheck and Helgrind do. > > If I remember correctly, --var-info was added to DRD before > --read-var-info was added to Memcheck or Helgrind. I have renamed the > DRD option --var-info to --read-var-info and left --var-info as an > undocumented option in DRD. Ah. But after your change there is now two --read-var-info options, one for the core and one for DRD. Which one takes precedence? Maybe both of the booleans get set... but it's not a good situation. The usage message becomes confusing as well. DRD may have had that flag first, but now that the core has it also it would be good if DRD instead used the core's version (VG_(clo_read_var_info)) and didn't look for --read-var-info itself. Nick |
|
From: Bart V. A. <bar...@gm...> - 2009-07-22 16:26:16
|
On Wed, Jul 22, 2009 at 10:10 AM, Nicholas Nethercote<n.n...@gm...> wrote: > On Wed, Jul 22, 2009 at 5:32 PM, Bart Van > Assche<bar...@gm...> wrote: >> >> There are two reasons why I added --auto-run-dsymutil=yes: >> * At least on the system I ran my tests on, the .dSYM directory was >> not built by default. >> * The message that suggests to add --auto-run-dsymutil=yes is hard to >> filter away from the regression test output because it consists of two >> lines of output. > > I'd prefer to work out why the dSYMs aren't being built for your > system. My mistake -- dSYMs were built for all executables generated by "make check" but not for one executable built through an explicit make command and that was disabled in drd/tests/Makefile.am through if-statements. Sorry for the confusion. Bart. |
|
From: Bart V. A. <bar...@gm...> - 2009-07-22 10:35:17
|
On Wed, Jul 22, 2009 at 10:14 AM, Julian Seward<js...@ac...> wrote: > >> > Also, how is DRD's --var-info=yes different to the core's >> > --read-var-info=yes? It seems like DRD should just use >> > --read-var-info=yes the way Memcheck and Helgrind do. >> >> If I remember correctly, --var-info was added to DRD before >> --read-var-info was added to Memcheck or Helgrind. I have renamed the >> DRD option --var-info to --read-var-info and left --var-info as an >> undocumented option in DRD. > > --read-var-info is a flag handled by the core, and applies to all > tools. It tells the debuginfo reader what to do. It's not handled > separately by all tools. The question of whether the tools can > actually make use of that extra info is a different question. > > So I think DRD shouldn't handle this flag at all. Fixed. By the way, I assume that the --read-var-info flag will be documented in docs/xml/manual-core.xml before 3.5.0 is released ? Bart. |
|
From: Nicholas N. <n.n...@gm...> - 2009-07-22 22:33:15
|
On Wed, Jul 22, 2009 at 8:35 PM, Bart Van Assche<bar...@gm...> wrote: > > Fixed. Thanks! > By the way, I assume that the --read-var-info flag will be > documented in docs/xml/manual-core.xml before 3.5.0 is released ? Good catch... it should have been documented in 3.4.0. I've filed bug 201169 (a 3.5.0 blocker) for it. Nick |