|
From: Julian S. <js...@ac...> - 2009-06-30 12:11:49
Attachments:
dcas_rebased0_val.diff.bz2
dcas_rebased0_vex.diff.bz2
|
Hi, I'd like to merge branches/DCAS to trunk in the next day or so. This branch makes Valgrind handle atomic instructions correctly: if atomic instructions enter the compilation pipeline, then they are preserved (in one way or another) in the instrumented code. This fixes problems in which Valgrinded code would not work correctly when using atomic instructions to communicate with other processes, or the kernel, via shared memory. Such problems usually appeared in the form of strange hangs or races. The change adds a new IR statement kind, IRStmt_CAS, which represents single- and doubleword compare-and-swap. This is used as the basis for the translation of all LOCK-prefixed instructions on x86 and amd64. The change also extends IRExpr_Load and IRStmt_Store so that load-linked and store-conditional operations can be represented. This facilitates correct translation of l[wd]arx and st[wd]cx. on ppc. As a result, the longstanding kludge for handling reservations on ppc is gone -- l[wd]arx and st[wd]cx. now "go through" to the hardware in the normal way. I have updated the instrumentation functions in all tools to handle the changes, with the exception of exp-ptrcheck, which needs some further work in order to be able to run threaded code. J |
|
From: Nicholas N. <n.n...@gm...> - 2009-07-01 03:14:27
|
On Tue, Jun 30, 2009 at 10:19 PM, Julian Seward<js...@ac...> wrote: > > I'd like to merge branches/DCAS to trunk in the next day or so. You don't have any additional tests in the Valgrind patch -- it seems like you probably should... preferably ones that failed previously but now pass. Once it's committed, can you please close https://bugs.kde.org/show_bug.cgi?id=197793? Also, could you look at these, which might now be closeable: https://bugs.kde.org/show_bug.cgi?id=85756 https://bugs.kde.org/show_bug.cgi?id=142103 https://bugs.kde.org/show_bug.cgi?id=195662 Thanks! Nick |
|
From: Julian S. <js...@ac...> - 2009-07-01 08:31:10
|
On Wednesday 01 July 2009, Nicholas Nethercote wrote: > On Tue, Jun 30, 2009 at 10:19 PM, Julian Seward<js...@ac...> wrote: > > I'd like to merge branches/DCAS to trunk in the next day or so. Done. > You don't have any additional tests in the Valgrind patch -- it seems There are some tests, but I forgot to include them in the patch (duh). I'll commit them in the next day or so. > Once it's committed, can you please close > https://bugs.kde.org/show_bug.cgi?id=197793? Done. > Also, could you look at these, which might now be closeable: > > https://bugs.kde.org/show_bug.cgi?id=85756 > https://bugs.kde.org/show_bug.cgi?id=142103 Closed as dups. > https://bugs.kde.org/show_bug.cgi?id=195662 Related, but not sure what's going on there. Have queried the submitted. J |