|
From: Vince W. <vi...@cs...> - 2009-04-15 04:53:45
|
Hello current valgrind SVN fails with the following error for me: gcc -m64 -g -Wno-long-long -Wno-pointer-sign -Wdeclaration-after-statement -fno-stack-protector -c -o libcoregrind_amd64_linux_a-m_cpuid.o test -f 'm_cpuid.S' || echo './'m_cpuid.S In file included from m_cpuid.S:31: pub_core_basics_asm.h:42:33: error: pub_tool_basics_asm.h: No such file or directory pub_core_basics_asm.h:45:20: error: config.h: No such file or directory make[3]: *** [libcoregrind_amd64_linux_a-m_cpuid.o] Error 1 make[3]: Leaving directory /fusion/research4/vince/valgrind/svn/valgrind/coregrind' I've bisected this down, the error was introduced at revision 9108 which re-organized how the includes are set up. I'm not sure what the best way to fix this is; a straight revert would probably fix it, but the proper fix is probably fixing Makefile.core.am to handle the includes properly. Vince |
|
From: Nicholas N. <n.n...@gm...> - 2009-04-15 05:55:29
Attachments:
diff
|
On Wed, Apr 15, 2009 at 2:53 PM, Vince Weaver <vi...@cs...> wrote: > Hello > > current valgrind SVN fails with the following error for me: > > gcc -m64 -g -Wno-long-long -Wno-pointer-sign -Wdeclaration-after-statement > -fno-stack-protector -c -o libcoregrind_amd64_linux_a-m_cpuid.o test -f > 'm_cpuid.S' || echo './'m_cpuid.S > In file included from m_cpuid.S:31: > pub_core_basics_asm.h:42:33: error: pub_tool_basics_asm.h: No such file or > directory > pub_core_basics_asm.h:45:20: error: config.h: No such file or directory > make[3]: *** [libcoregrind_amd64_linux_a-m_cpuid.o] Error 1 > make[3]: Leaving directory > /fusion/research4/vince/valgrind/svn/valgrind/coregrind' > > > I've bisected this down, the error was introduced at revision 9108 > which re-organized how the includes are set up. > > I'm not sure what the best way to fix this is; a straight revert would > probably fix it, but the proper fix is probably fixing Makefile.core.am > to handle the includes properly. There's a current thread on valgrind-users "can't compile valgrind, fails in make" about this. Basically, I think it's because you have an old automake that does the wrong thing -- what version do you have? And if you try the attached patch, I think that will fix it. Nick |
|
From: Vince W. <vi...@cs...> - 2009-04-15 16:02:02
|
On Wed, 15 Apr 2009, Nicholas Nethercote wrote: > There's a current thread on valgrind-users "can't compile valgrind, > fails in make" about this. Basically, I think it's because you have > an old automake that does the wrong thing -- what version do you have? Ahh, I didn't think to check the valgrind-users list. Probably would have saved me a bit of time on bisection. The one machine I tested on was an older one, running SuSE 10.1 which has automake 1.9.6 I also tried on a current debian-unstable system which I would have thought would have had a more modern automake, but oddly it is using automake 1.7.9 > And if you try the attached patch, I think that will fix it. yes, it seems to fix it. Thanks Vince |