|
From: Florian K. <br...@ac...> - 2011-12-09 00:06:40
Attachments:
demangle-patch
|
Hello, the last C++ demangler update happened in Oct 2008. In the meantime C++11 came out, and GCC has been implementing the new language features for a while now. Time for us to pick up the demangler updates before somebody starts complaining. The timing is good. GCC trunk is in stage 3, i.e. only bug fixes allowed. So things should be sufficiently stable. I did not spot any license changes. They would be visible in the attached patch which is based on GCC r181975. Any objections to applying it? Florian PS: For the curious.. the patch was generated by diff'ing the relavant files from GCC r141363 against coregrind/m_demangle and applying those differences to the demangling related files from r181975. |
|
From: Bart V. A. <bva...@ac...> - 2011-12-09 07:03:01
|
On Fri, Dec 9, 2011 at 1:06 AM, Florian Krohm <br...@ac...> wrote: > the last C++ demangler update happened in Oct 2008. In the meantime > C++11 came out, and GCC has been implementing the new language features > for a while now. Time for us to pick up the demangler updates before > somebody starts complaining. > The timing is good. GCC trunk is in stage 3, i.e. only bug fixes > allowed. So things should be sufficiently stable. I did not spot any > license changes. They would be visible in the attached patch which is > based on GCC r181975. Does the GCC source tree contain any demangler regression tests ? Bart. |
|
From: Florian K. <br...@ac...> - 2011-12-09 13:10:30
|
On 12/09/2011 02:02 AM, Bart Van Assche wrote: > On Fri, Dec 9, 2011 at 1:06 AM, Florian Krohm <br...@ac...> wrote: >> the last C++ demangler update happened in Oct 2008. In the meantime >> C++11 came out, and GCC has been implementing the new language features >> for a while now. Time for us to pick up the demangler updates before >> somebody starts complaining. >> The timing is good. GCC trunk is in stage 3, i.e. only bug fixes >> allowed. So things should be sufficiently stable. I did not spot any >> license changes. They would be visible in the attached patch which is >> based on GCC r181975. > > Does the GCC source tree contain any demangler regression tests ? > Sure: gcc/testsuite/g++.dg/abi Florian |
|
From: Julian S. <js...@ac...> - 2011-12-09 13:55:40
|
> The timing is good. GCC trunk is in stage 3, i.e. only bug fixes > allowed. So things should be sufficiently stable. I did not spot any > license changes. They would be visible in the attached patch which is > based on GCC r181975. > Any objections to applying it? Sounds good to me; pls do. btw I think there are 3 places where you needed to change the text 141363 to 181975 but you only got 2 of them (or maybe deliberate). Anyway, thanks for doing this. J |
|
From: Florian K. <br...@ac...> - 2011-12-10 16:08:03
|
On 12/09/2011 08:55 AM, Julian Seward wrote: > >> The timing is good. GCC trunk is in stage 3, i.e. only bug fixes >> allowed. So things should be sufficiently stable. I did not spot any >> license changes. They would be visible in the attached patch which is >> based on GCC r181975. >> Any objections to applying it? > > Sounds good to me; pls do. btw I think there are 3 places where you > needed to change the text 141363 to 181975 but you only got 2 of them > (or maybe deliberate). > Done in r12281. That non-change of the revision number was deliberate. Florian |