|
From: <sv...@va...> - 2011-05-18 10:12:45
|
Author: bart Date: 2011-05-18 11:12:36 +0100 (Wed, 18 May 2011) New Revision: 11774 Log: Added missing extern keywords. Patch provided by Daniel Richard G. - closes #275536. Modified: trunk/drd/drd_cond.c Modified: trunk/drd/drd_cond.c =================================================================== --- trunk/drd/drd_cond.c 2011-05-18 06:04:00 UTC (rev 11773) +++ trunk/drd/drd_cond.c 2011-05-18 10:12:36 UTC (rev 11774) @@ -48,8 +48,8 @@ /* Global variables. */ -Addr DRD_(pthread_cond_initializer); -int DRD_(pthread_cond_initializer_size); +extern Addr DRD_(pthread_cond_initializer); +extern int DRD_(pthread_cond_initializer_size); /* Function definitions. */ |
|
From: Florian K. <br...@ac...> - 2011-05-18 14:41:31
|
On 05/18/2011 06:12 AM, sv...@va... wrote: > Author: bart > Date: 2011-05-18 11:12:36 +0100 (Wed, 18 May 2011) > New Revision: 11774 > > Log: > Added missing extern keywords. Patch provided by Daniel Richard G. - closes #275536. > > Modified: > trunk/drd/drd_cond.c > > > Modified: trunk/drd/drd_cond.c > =================================================================== > --- trunk/drd/drd_cond.c 2011-05-18 06:04:00 UTC (rev 11773) > +++ trunk/drd/drd_cond.c 2011-05-18 10:12:36 UTC (rev 11774) > @@ -48,8 +48,8 @@ > > /* Global variables. */ > > -Addr DRD_(pthread_cond_initializer); > -int DRD_(pthread_cond_initializer_size); > +extern Addr DRD_(pthread_cond_initializer); > +extern int DRD_(pthread_cond_initializer_size); > > Are these declarations necessary? These variables are declared in drd_cond.h which is already included in drd_cond.c. So they are kind of redundant. Florian |
|
From: Bart V. A. <bva...@ac...> - 2011-05-18 16:13:00
|
On Wed, May 18, 2011 at 4:41 PM, Florian Krohm <br...@ac...> wrote: > On 05/18/2011 06:12 AM, sv...@va... wrote: >> Author: bart >> Date: 2011-05-18 11:12:36 +0100 (Wed, 18 May 2011) >> New Revision: 11774 >> >> Log: >> Added missing extern keywords. Patch provided by Daniel Richard G. - closes #275536. >> >> Modified: >> trunk/drd/drd_cond.c >> >> >> Modified: trunk/drd/drd_cond.c >> =================================================================== >> --- trunk/drd/drd_cond.c 2011-05-18 06:04:00 UTC (rev 11773) >> +++ trunk/drd/drd_cond.c 2011-05-18 10:12:36 UTC (rev 11774) >> @@ -48,8 +48,8 @@ >> >> /* Global variables. */ >> >> -Addr DRD_(pthread_cond_initializer); >> -int DRD_(pthread_cond_initializer_size); >> +extern Addr DRD_(pthread_cond_initializer); >> +extern int DRD_(pthread_cond_initializer_size); > > Are these declarations necessary? These variables are declared in > drd_cond.h which is already included in drd_cond.c. So they are kind of > redundant. You are right - these two declarations have been removed via r11778. Bart. |