|
From: Mark P. <pa...@un...> - 2015-04-12 23:19:15
Attachments:
signature.asc
|
Hi there, It looks like valgrind HEAD is busted for those of us living on bleeding 10.10.
The two main issues are that the configure.am file is a bit too strict for Apple LLVM checking, and someone made a breaking change to the initimg interfaces without making sure to un-bust initimg-darwin.c
The following patch worked like a charm for myself:
Index: configure.ac
===================================================================
--- configure.ac (revision 15085)
+++ configure.ac (working copy)
@@ -154,7 +154,7 @@
# Note: m4 arguments are quoted with [ and ] so square brackets in shell
# statements have to be quoted.
case "${is_clang}-${gcc_version}" in
- applellvm-5.1|applellvm-6.0*)
+ applellvm-5.1|applellvm-6.*)
AC_MSG_RESULT([ok (Apple LLVM version ${gcc_version})])
;;
icc-1[[3-9]].*)
Index: coregrind/m_initimg/initimg-darwin.c
===================================================================
--- coregrind/m_initimg/initimg-darwin.c (revision 15085)
+++ coregrind/m_initimg/initimg-darwin.c (working copy)
@@ -312,7 +312,8 @@
HChar** orig_envp,
const ExeInfo* info,
Addr clstack_end,
- SizeT clstack_max_size )
+ SizeT clstack_max_size,
+ const VexArchInfo* vex_archinfo )
{
HChar **cpp;
HChar *strtab; /* string table */
@@ -508,7 +509,8 @@
/*====================================================================*/
/* Create the client's initial memory image. */
-IIFinaliseImageInfo VG_(ii_create_image)( IICreateImageInfo iicii )
+IIFinaliseImageInfo VG_(ii_create_image)( IICreateImageInfo iicii,
+ const VexArchInfo* vex_archinfo )
{
ExeInfo info;
VG_(memset)( &info, 0, sizeof(info) );
@@ -548,7 +550,8 @@
iifii.initial_client_SP =
setup_client_stack( iicii.argv - 1, env, &info,
- iicii.clstack_end, iifii.clstack_max_size );
+ iicii.clstack_end, iifii.clstack_max_size,
+ vex_archinfo );
VG_(free)(env);
thanks,
-Pauley
|
|
From: Julian S. <js...@ac...> - 2015-04-13 11:44:10
|
On 13/04/15 00:50, Mark Pauley wrote: > a breaking change to the initimg interfaces without making sure > to un-bust initimg-darwin.c Ach; that is my bad really, for failing to set up or arrange to have set up, a nightly builder for MacOSX. > configure.am file is a bit too strict for Apple LLVM checking, Committed as r15087 and r15088. Thanks for the fixes. J |
|
From: Rhys K. <rhy...@gm...> - 2015-04-13 11:57:57
|
Thanks Mark for the patch. On Monday, 13 April 2015, Julian Seward <js...@ac...> wrote: > On 13/04/15 00:50, Mark Pauley wrote: > > > a breaking change to the initimg interfaces without making sure > > to un-bust initimg-darwin.c > > Ach; that is my bad really, for failing to set up or arrange to have > set up, a nightly builder for MacOSX. > > > configure.am file is a bit too strict for Apple LLVM checking, > > Committed as r15087 and r15088. Thanks for the fixes. > > J > > > > ------------------------------------------------------------------------------ > BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT > Develop your own process in accordance with the BPMN 2 standard > Learn Process modeling best practices with Bonita BPM through live > exercises > http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- > event?utm_ > source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF > _______________________________________________ > Valgrind-developers mailing list > Val...@li... <javascript:;> > https://lists.sourceforge.net/lists/listinfo/valgrind-developers > |