|
From: Christian B. <bor...@de...> - 2010-10-06 10:15:01
Attachments:
fixltp.patch
|
The following ltp testcase trigger a VALGRIND INTERNAL ERROR by having wrong system call input: bind01 connect01 io_submit01 recvmsg01 rt_sigaction02 rt_sigprocmask02 sendto01 setrlimit02 Here is a patch that uses ML_(valid_client_addr) to check memory that is inspected by our syscall wrappers. Please review and apply if appropriate. Do you need a bugzilla? Is one bugzilla for all system calls ok? Credits for finding the bug go to Stefan Wild from our test department. Christian |
|
From: Christian B. <bor...@de...> - 2010-10-06 10:26:03
Attachments:
fixltp.patch
|
Am 06.10.2010 12:14, schrieb Christian Borntraeger: > The following ltp testcase trigger a VALGRIND INTERNAL ERROR by having wrong system call input: > > bind01 > connect01 > io_submit01 > recvmsg01 > rt_sigaction02 > rt_sigprocmask02 > sendto01 > setrlimit02 > > Here is a patch that uses ML_(valid_client_addr) to check memory that is > inspected by our syscall wrappers. Please review and apply if appropriate. > > Do you need a bugzilla? Is one bugzilla for all system calls ok? > > Credits for finding the bug go to Stefan Wild from our test department. > > > Christian Sorry, I attached an unrefreshed patch, here is a new one. |
|
From: Christian B. <bor...@de...> - 2010-10-11 07:25:18
Attachments:
fixsockaddr.patch
|
There are more failures when the test uses memcheck instead of nullgrind: accept01, getsockname01 and getpeername01 fail with something like --18618-- VALGRIND INTERNAL ERROR: Valgrind received a signal 11 (SIGSEGV) - exiting --18618-- si_code=1; Faulting address: 0x0; sp: 0x403b6a9d0 valgrind: the 'impossible' happened: Killed by fatal signal ==18618== at 0x401074328: vgModuleLocal_buf_and_len_pre_check (syswrap-generic.c:1000) ==18618== by 0x40107464B: vgModuleLocal_generic_PRE_sys_getpeername (syswrap-generic.c:1493) ==18618== by 0x401073A53: vgPlain_client_syscall (syswrap-main.c:1490) ==18618== by 0x40106F963: handle_syscall (scheduler.c:899) The attached patch fixes the problem but the accept01 test also shows that I should not use ML_(valid_client_addr) but VG_(am_is_valid_for_client) instead for my first patch, since we cannot dereference memory that belongs to a reservation. I will attach this patch to the bugzilla and will also replace the other one. (https://bugs.kde.org/show_bug.cgi?id=253383) |
|
From: Julian S. <js...@ac...> - 2010-10-06 11:06:10
|
On Wednesday, October 06, 2010, Christian Borntraeger wrote: > The following ltp testcase trigger a VALGRIND INTERNAL ERROR by having > wrong system call input [...] > > Do you need a bugzilla? Is one bugzilla for all system calls ok? Excellent work, but please .. put it in bugzilla, so it can be tracked properly. Patches that go only to the mailing list tend to get forgotten about. J |