|
From: Duncan T. <dun...@gm...> - 2010-01-25 16:20:32
Attachments:
valgrind-3.5.0-quadrics-patch-partial
|
Hi The Quadrics elan4 network card driver uses a large number of ioctls when interacting with userspace code. Quadrics provide a patch to valgrind 3.3 to allow valgrind to check the use of these ioctls. I've started updating this patch to valgrind 3.5.0 and I'm trying to follow the coding style so that it is mergable. It is currently unfinished, though the ioctls implemented are correct. Two questions: Is trying to get this into a mergable form useful? And if so, am I doing anything obviously wrong? The Quadrics drivers are now maintained by Vega Consulting, and support.hpc.vega.co.uk Thanks -- Duncan Thomas |
|
From: Tom H. <to...@co...> - 2010-01-25 16:41:13
|
On 25/01/10 16:20, Duncan Thomas wrote: > The Quadrics elan4 network card driver uses a large number of ioctls > when interacting with userspace code. Quadrics provide a patch to > valgrind 3.3 to allow valgrind to check the use of these ioctls. I've > started updating this patch to valgrind 3.5.0 and I'm trying to follow > the coding style so that it is mergable. It is currently unfinished, > though the ioctls implemented are correct. Two questions: Is trying to > get this into a mergable form useful? And if so, am I doing anything > obviously wrong? Is the driver in the standard kernel.org kernel? We generally only support system calls which are in the standard kernel, which may be why this never got merged before if it's for an out-of-tree driver. Tom -- Tom Hughes (to...@co...) http://www.compton.nu/ |