|
From: Dodji S. <do...@re...> - 2009-09-30 13:27:49
|
Hello Valgrind Hackers, The bug https://bugs.kde.org/show_bug.cgi?id=206013 prevents valgrind from redirecting the new STT_GNU_IFUNC type of functions (a.k.a. indirect functions) exposed by recent versions of the linux binutils. You can read about STT_GNU_IFUNC functions by reading its specification at http://www.x86-64.org/pipermail/discuss/2009-June/010553.html . I have attached to the bug linked above an early patch to support redirecting STT_GNU_IFUNC. I have also installed a couple of indirect function redirections just to see that Valgrind rightfully stops emitting false positives on my test cases. Then I noticed that some people rather post their patches to this list. So I thought I should maybe post a link to the patch here as well. I apologise in advance if it appears to be too much noise. In any case, please let me know. I would welcome any comment about the approach of the patch, and proceed forward in the direction that will result from the discussions. This is my first patch to Valgrind, so please, bear with me :-) Thanks. -- Dodji Seketeli Red Hat, Inc. |
|
From: Tom H. <to...@co...> - 2009-09-30 14:24:01
|
On 30/09/09 14:26, Dodji Seketeli wrote: > Then I noticed that some people rather post their patches to this list. So > I thought I should maybe post a link to the patch here as well. I apologise > in advance if it appears to be too much noise. In any case, please let me know. Putting it on the bug is fine. That's our preferred place for such things so that they don't get forgotten. If nobody else deals with it first then I will probably wind up looking at it in a few weeks when F12 is out Tom -- Tom Hughes (to...@co...) http://www.compton.nu/ |
|
From: Dodji S. <do...@re...> - 2009-09-30 15:31:11
|
Le 30/09/2009 16:23, Tom Hughes a écrit : > Putting it on the bug is fine. That's our preferred place for such > things so that they don't get forgotten. Thanks. > If nobody else deals with it first then I will probably wind up looking > at it in a few weeks when F12 is out Thank you very much. In any case, I can spend time working on this before F12 comes out though. I just wanted to have you guys feedback to in case I am headed in the wrong direction :) I didn't mean to dump all the work on your shoulders. Thanks for you quick response. Cheers. -- Dodji Seketeli Red Hat, Inc. |
|
From: Tom H. <to...@co...> - 2009-09-30 15:32:31
|
On 30/09/09 16:29, Dodji Seketeli wrote: > Le 30/09/2009 16:23, Tom Hughes a écrit : > >> If nobody else deals with it first then I will probably wind up looking >> at it in a few weeks when F12 is out > > Thank you very much. In any case, I can spend time working on this > before F12 comes out though. Sure, but I've got no way to play with it until I've upgraded something to F12 unless I can be bothered to install a rawhide VM or something... Tom -- Tom Hughes (to...@co...) http://www.compton.nu/ |
|
From: Dodji S. <do...@re...> - 2009-09-30 15:43:24
|
Le 30/09/2009 17:32, Tom Hughes a écrit : >> Thank you very much. In any case, I can spend time working on this >> before F12 comes out though. > > Sure, but I've got no way to play with it until I've upgraded something > to F12 unless I can be bothered to install a rawhide VM or something... No problem, really. I fully understand this. I was just proposing my help in case you would want me to try out things for you if necessary. Please do not put more burden on yourself than you would have planned. Cheers. -- Dodji Seketeli Red Hat, Inc. |