|
From: Nicholas N. <n.n...@gm...> - 2009-02-23 04:43:44
|
Hi, Pretty much every file in Valgrind gets $(WERROR) as part of the compile flags. But I can't work out what it's for -- that string isn't present in the info pages for automake, autoconf or make, nor is it defined in configure.in or any of our generated Makefiles. AFAICT it's always empty (at least, on Linux and Darwin where I've checked). So I'd like to get rid of it, unless someone can identify what it's for. Nick |
|
From: Bart V. A. <bar...@gm...> - 2009-02-23 07:14:33
|
On Mon, Feb 23, 2009 at 5:43 AM, Nicholas Nethercote <n.n...@gm...> wrote: > Pretty much every file in Valgrind gets $(WERROR) as part of the > compile flags. But I can't work out what it's for -- that string > isn't present in the info pages for automake, autoconf or make, nor is > it defined in configure.in or any of our generated Makefiles. AFAICT > it's always empty (at least, on Linux and Darwin where I've checked). > > So I'd like to get rid of it, unless someone can identify what it's for. My guess is that this flag can be used as follows (I don't use this flag): make WERROR=-Werror Bart. |
|
From: Julian S. <js...@ac...> - 2009-02-23 13:04:02
|
> So I'd like to get rid of it, unless someone can identify what it's for. I suspect it was part of some early scheme at having WERROR optionally available. Problem with -Werror is that even just with the normal -Wall, it's impossible to make V compile warning-free on all platforms, and so a hardwired -Werror often breaks the build. I say rm it; I have never used. J |
|
From: Stefan K. <en...@ho...> - 2009-02-24 19:23:24
|
Bart Van Assche schrieb: > On Mon, Feb 23, 2009 at 5:43 AM, Nicholas Nethercote > <n.n...@gm...> wrote: >> Pretty much every file in Valgrind gets $(WERROR) as part of the >> compile flags. But I can't work out what it's for -- that string >> isn't present in the info pages for automake, autoconf or make, nor is >> it defined in configure.in or any of our generated Makefiles. AFAICT >> it's always empty (at least, on Linux and Darwin where I've checked). >> >> So I'd like to get rid of it, unless someone can identify what it's for. > > My guess is that this flag can be used as follows (I don't use this flag): > > make WERROR=-Werror > > Bart. > but then you can anyway do make CFLAGS=-Werror :) Stefan |
|
From: Bart V. A. <bar...@gm...> - 2009-02-25 17:21:28
|
On Tue, Feb 24, 2009 at 8:23 PM, Stefan Kost <en...@ho...> wrote: > but then you can anyway do > make CFLAGS=-Werror > :) What will the above command to with the CFLAGS variable that has already been defined in each Makefile ? $ grep '^CFLAGS =' Makefile CFLAGS = -Wno-long-long -Wno-pointer-sign -Wdeclaration-after-statement -fno-stack-protector Bart. |
|
From: Stefan K. <en...@ho...> - 2009-02-26 15:48:46
|
Bart Van Assche schrieb: > On Tue, Feb 24, 2009 at 8:23 PM, Stefan Kost <en...@ho...> wrote: > >> but then you can anyway do >> make CFLAGS=-Werror >> :) >> > > What will the above command to with the CFLAGS variable that has > already been defined in each Makefile ? > > $ grep '^CFLAGS =' Makefile > CFLAGS = -Wno-long-long -Wno-pointer-sign > -Wdeclaration-after-statement -fno-stack-protector > > You should not override CFLAGS in Makefile.am. You can set AM_CFLAGS. Have a look at http://www.lrde.epita.fr/~adl/autotools.html (be aware its quite long). Stefan > Bart. > |
|
From: Konstantin S. <kon...@gm...> - 2009-02-25 18:01:21
|
On Wed, Feb 25, 2009 at 8:21 PM, Bart Van Assche <bar...@gm...> wrote: > On Tue, Feb 24, 2009 at 8:23 PM, Stefan Kost <en...@ho...> wrote: >> but then you can anyway do >> make CFLAGS=-Werror >> :) > > What will the above command to with the CFLAGS variable that has > already been defined in each Makefile ? make CFLAGS+=-Werror note "+=" > > $ grep '^CFLAGS =' Makefile > CFLAGS = -Wno-long-long -Wno-pointer-sign > -Wdeclaration-after-statement -fno-stack-protector > > Bart. > > ------------------------------------------------------------------------------ > Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA > -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise > -Strategies to boost innovation and cut costs with open source participation > -Receive a $600 discount off the registration fee with the source code: SFAD > http://p.sf.net/sfu/XcvMzF8H > _______________________________________________ > Valgrind-developers mailing list > Val...@li... > https://lists.sourceforge.net/lists/listinfo/valgrind-developers > |
|
From: Bart V. A. <bar...@gm...> - 2009-02-25 18:24:29
|
On Wed, Feb 25, 2009 at 7:01 PM, Konstantin Serebryany <kon...@gm...> wrote: > On Wed, Feb 25, 2009 at 8:21 PM, Bart Van Assche > <bar...@gm...> wrote: >> On Tue, Feb 24, 2009 at 8:23 PM, Stefan Kost <en...@ho...> wrote: >>> but then you can anyway do >>> make CFLAGS=-Werror >>> :) >> >> What will the above command to with the CFLAGS variable that has >> already been defined in each Makefile ? > > make CFLAGS+=-Werror > > note "+=" I have tried the above command, but it had the same effect as make CFLAGS=-Werror -- the CFLAGS defined in the Makefile were discarded. Bart. |
|
From: Konstantin S. <kon...@gm...> - 2009-02-26 10:41:57
|
On Wed, Feb 25, 2009 at 9:24 PM, Bart Van Assche <bar...@gm...> wrote: > On Wed, Feb 25, 2009 at 7:01 PM, Konstantin Serebryany > <kon...@gm...> wrote: >> On Wed, Feb 25, 2009 at 8:21 PM, Bart Van Assche >> <bar...@gm...> wrote: >>> On Tue, Feb 24, 2009 at 8:23 PM, Stefan Kost <en...@ho...> wrote: >>>> but then you can anyway do >>>> make CFLAGS=-Werror >>>> :) >>> >>> What will the above command to with the CFLAGS variable that has >>> already been defined in each Makefile ? >> >> make CFLAGS+=-Werror >> >> note "+=" > > I have tried the above command, but it had the same effect as make > CFLAGS=-Werror -- the CFLAGS defined in the Makefile were discarded. Oops. Yes, indeed. > > Bart. > |