|
From: Mark W. <ma...@so...> - 2023-04-21 14:17:16
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=9d6d45cfdebc62099640d8ae566dc9c8577ba514 commit 9d6d45cfdebc62099640d8ae566dc9c8577ba514 Author: Mark Wielaard <ma...@kl...> Date: Fri Apr 21 16:15:15 2023 +0200 Add cachegrind/tests/ann-diff4b-aux/w.rs Missing testfile from commit 1fdf0e728a047f0aab4de805576b6a3a84f37b79 "Add diff and merge capability to `cg_annotate`." Diff: --- cachegrind/tests/ann-diff4b-aux/w.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cachegrind/tests/ann-diff4b-aux/w.rs b/cachegrind/tests/ann-diff4b-aux/w.rs new file mode 100644 index 0000000000..4cb29ea38f --- /dev/null +++ b/cachegrind/tests/ann-diff4b-aux/w.rs @@ -0,0 +1,3 @@ +one +two +three |
|
From: Nicholas N. <n.n...@gm...> - 2023-04-21 23:53:43
|
Failing to add test files to Makefile.am is a really easy mistake to make, and one I've done multiple times recently. Mark, you've often fixed these, how do you detect them? I did a try push beforehand and it didn't detect the missing file. Nick On Sat, 22 Apr 2023 at 00:18, Mark Wielaard <ma...@so...> wrote: > > https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=9d6d45cfdebc62099640d8ae566dc9c8577ba514 > > commit 9d6d45cfdebc62099640d8ae566dc9c8577ba514 > Author: Mark Wielaard <ma...@kl...> > Date: Fri Apr 21 16:15:15 2023 +0200 > > Add cachegrind/tests/ann-diff4b-aux/w.rs > > Missing testfile from commit 1fdf0e728a047f0aab4de805576b6a3a84f37b79 > "Add diff and merge capability to `cg_annotate`." > > Diff: > --- > cachegrind/tests/ann-diff4b-aux/w.rs | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/cachegrind/tests/ann-diff4b-aux/w.rs > b/cachegrind/tests/ann-diff4b-aux/w.rs > new file mode 100644 > index 0000000000..4cb29ea38f > --- /dev/null > +++ b/cachegrind/tests/ann-diff4b-aux/w.rs > @@ -0,0 +1,3 @@ > +one > +two > +three > > > _______________________________________________ > Valgrind-developers mailing list > Val...@li... > https://lists.sourceforge.net/lists/listinfo/valgrind-developers > |
|
From: Paul F. <pj...@wa...> - 2023-04-22 10:53:24
|
On 22-04-23 01:53, Nicholas Nethercote wrote: > Failing to add test files to Makefile.am is a really easy mistake to > make, and one I've done multiple times recently. Mark, you've often > fixed these, how do you detect them? I did a try push beforehand and it > didn't detect the missing file. Hi Nick [g]make post-regtest-checks does checking that the Makefile.am EXTRA_DIST matches the .exp files (and probably more). It also gets executed, as the name implies, by [g]make regtest. You can run it directly, for instance from the top directory tests/post_regtest_checks . dhat ...checking makefile consistency ...checking header files and include directives A+ Paul |
|
From: Mark W. <ma...@kl...> - 2023-04-22 18:30:12
|
On Sat, Apr 22, 2023 at 09:53:22AM +1000, Nicholas Nethercote wrote: > Failing to add test files to Makefile.am is a really easy mistake to make, > and one I've done multiple times recently. Mark, you've often fixed these, > how do you detect them? I did a try push beforehand and it didn't detect > the missing file. There are two ways. make regtest does a quick check. Paul pointed out that can also be triggered by make post-regtest-checks. Maybe we should make that part of make check instead? The other is make distcheck. Which creates a dist and then tries to do a buid and make check (plus a srcdir != builddir build). The fedora-latest builder actually does a make distcheck, but since make auxchecks fails there it isn't in the try builders and doesn't show up as a new failure. I'll remove the auxchecks step and add it to the try builders. Cheers, Mark |