|
From: Philippe W. <phi...@sk...> - 2023-04-18 11:02:58
|
The nightly build script produces a mail that indicates if there is a difference between the results of one day ago and the new results. When no difference, the mail subject contains 'unchanged'. It looks like the 'unchanged' logic is broken due to the addition of the time taken to run tests. It would be good to keep the 'unchanged' marker only depending on the functional results. Thanks Philippe |
|
From: Mark W. <ma...@kl...> - 2023-04-20 20:14:08
|
Hi Philippe,
On Tue, Apr 18, 2023 at 01:02:44PM +0200, Philippe Waroquiers via Valgrind-developers wrote:
> The nightly build script produces a mail that indicates if there is
> a difference between the results of one day ago and the new results.
>
> When no difference, the mail subject contains 'unchanged'.
>
> It looks like the 'unchanged' logic is broken due to the addition of
> the time taken to run tests.
>
> It would be good to keep the 'unchanged' marker only depending on
> the functional results.
Sorry, I hadn't realized that would change the diff emails.
Paul has added a workaround:
commit 04054f36be59eeb337f23932424a7e70bbfeba70
Author: Paul Floyd <pj...@wa...>
Date: Tue Apr 18 21:18:12 2023 +0200
regtest: try to make the nightly script independent of test times
Which adds a sed filter that deletes the timing info from the log
files.
It does have to be installed on some of the nightly builders though.
Cheers,
Mark
|