|
From: Rosen P. <ro...@gm...> - 2019-12-12 01:01:56
|
Fails compilation:
{standard input}: Assembler messages:
{standard input}:1163: Error: invalid operands `srl $0,$0,13'
{standard input}:1164: Error: invalid operands `srl $0,$0,29'
{standard input}:1165: Error: invalid operands `srl $0,$0,3'
{standard input}:1166: Error: invalid operands `srl $0,$0,19'
{standard input}:1167: Error: invalid operands `or $13,$13,$13'
Signed-off-by: Rosen Penev <ro...@gm...>
---
include/valgrind.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/valgrind.h b/include/valgrind.h
index 663d433b5..ebc9b07f6 100644
--- a/include/valgrind.h
+++ b/include/valgrind.h
@@ -157,7 +157,7 @@
# define PLAT_s390x_linux 1
#elif defined(__linux__) && defined(__mips__) && (__mips==64)
# define PLAT_mips64_linux 1
-#elif defined(__linux__) && defined(__mips__) && (__mips!=64)
+#elif defined(__linux__) && defined(__mips__) && (__mips!=64) && !defined(__mips16)
# define PLAT_mips32_linux 1
#elif defined(__sun) && defined(__i386__)
# define PLAT_x86_solaris 1
--
2.23.0
|
|
From: Rosen P. <ro...@gm...> - 2019-12-16 18:02:47
|
Fails compilation:
{standard input}: Assembler messages:
{standard input}:1163: Error: invalid operands `srl $0,$0,13'
{standard input}:1164: Error: invalid operands `srl $0,$0,29'
{standard input}:1165: Error: invalid operands `srl $0,$0,3'
{standard input}:1166: Error: invalid operands `srl $0,$0,19'
{standard input}:1167: Error: invalid operands `or $13,$13,$13'
Signed-off-by: Rosen Penev <ro...@gm...>
---
v2: Simplified the if condition.
include/valgrind.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/valgrind.h b/include/valgrind.h
index 663d433b5..9323e2c00 100644
--- a/include/valgrind.h
+++ b/include/valgrind.h
@@ -157,7 +157,7 @@
# define PLAT_s390x_linux 1
#elif defined(__linux__) && defined(__mips__) && (__mips==64)
# define PLAT_mips64_linux 1
-#elif defined(__linux__) && defined(__mips__) && (__mips!=64)
+#elif defined(__linux__) && defined(__mips__) && (__mips==32)
# define PLAT_mips32_linux 1
#elif defined(__sun) && defined(__i386__)
# define PLAT_x86_solaris 1
--
2.23.0
|
|
From: Petar J. <mip...@gm...> - 2019-12-17 17:32:06
|
> > Fails compilation: > I have applied this patch as it is OK, but note that Valgrind does not support mips16 and I see no use in building it for mips16. Can you elaborate a little bit on what you are trying to achieve? Regards, Petar |
|
From: Rosen P. <ro...@gm...> - 2019-12-17 20:04:39
|
On Tue, Dec 17, 2019 at 9:32 AM Petar Jovanovic <mip...@gm...> wrote: > > > > > Fails compilation: > > > I have applied this patch as it is OK, but note that Valgrind does not > support mips16 and I see no use in building it for mips16. > Can you elaborate a little bit on what you are trying to achieve? Get it to compile. Note that glib2 also uses this header. More info: https://github.com/openwrt/packages/pull/10780 > > Regards, > Petar |
|
From: Matthias S. <zz...@ge...> - 2019-12-17 20:05:13
|
Am 17.12.19 um 18:31 schrieb Petar Jovanovic: >> >> Fails compilation: >> > I have applied this patch as it is OK, but note that Valgrind does not > support mips16 and I see no use in building it for mips16. > Can you elaborate a little bit on what you are trying to achieve? > I never used mips, but I understand the reason for the patch: Exclude platforms that are not supported by valgrind from valgrind.h. Then any user-code can unconditionally include valgrind.h and call client-requests without additional checks that valgrind supports the platform or not. On unsupported platforms the macros just end up empty. Regards Matthias |
|
From: Petar J. <mip...@gm...> - 2019-12-17 22:53:33
|
On Tue, Dec 17, 2019 at 9:05 PM Matthias Schwarzott <zz...@ge...> wrote: > > I never used mips, but I understand the reason for the patch: > Exclude platforms that are not supported by valgrind from valgrind.h. > > Then any user-code can unconditionally include valgrind.h and call > client-requests without additional checks that valgrind supports the > platform or not. > > On unsupported platforms the macros just end up empty. > I understand what you are saying. My reply was not whether or not to include the patch (it is already in), but rather a note that Valgrind does not support mips16 (in case someone is making an attempt to build it for mips16). Regards, Petar |