|
From: Rhys K. <rhy...@so...> - 2019-03-11 12:01:08
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=3cd099ab5f2571f06102f0f007df91a17106e06d commit 3cd099ab5f2571f06102f0f007df91a17106e06d Author: Rhys Kidd <rhy...@gm...> Date: Sat Feb 2 18:22:16 2019 -0500 macOS: Don't duplicate -fno-stack-protector Since f38d96d -fno-stack-protector has been added to $(AM_CFLAGS_BASE) on all platforms, if the compiler supports it. Accordingly, there's no need to still add this a second time specifically for macOS. Fixes: f38d96d ("Add -Wformat -Wformat-security to the list of compile flags.") Signed-off-by: Rhys Kidd <rhy...@gm...> Diff: --- Makefile.all.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.all.am b/Makefile.all.am index 2ad5403..daa7e41 100644 --- a/Makefile.all.am +++ b/Makefile.all.am @@ -222,14 +222,14 @@ AM_CCASFLAGS_ARM64_LINUX = @FLAG_M64@ -g AM_FLAG_M3264_X86_DARWIN = -arch i386 AM_CFLAGS_X86_DARWIN = $(WERROR) -arch i386 $(AM_CFLAGS_BASE) \ -mmacosx-version-min=10.6 \ - -fno-stack-protector -fno-pic -fno-PIC + -fno-pic -fno-PIC AM_CFLAGS_PSO_X86_DARWIN = $(AM_CFLAGS_X86_DARWIN) $(AM_CFLAGS_PSO_BASE) AM_CCASFLAGS_X86_DARWIN = -arch i386 -g AM_FLAG_M3264_AMD64_DARWIN = -arch x86_64 AM_CFLAGS_AMD64_DARWIN = $(WERROR) -arch x86_64 $(AM_CFLAGS_BASE) \ - -mmacosx-version-min=10.6 -fno-stack-protector + -mmacosx-version-min=10.6 AM_CFLAGS_PSO_AMD64_DARWIN = $(AM_CFLAGS_AMD64_DARWIN) $(AM_CFLAGS_PSO_BASE) AM_CCASFLAGS_AMD64_DARWIN = -arch x86_64 -g |