|
From: <sv...@va...> - 2015-08-23 14:37:54
|
Author: rhyskidd
Date: Sun Aug 23 15:37:47 2015
New Revision: 15585
Log:
docs: env variable handling behaviour consistent between OS X and Linux, thus remove redundant comment and #ifdef. n-i-bz.
Modified:
trunk/coregrind/m_libcproc.c
trunk/docs/internals/Darwin-notes.txt
Modified: trunk/coregrind/m_libcproc.c
==============================================================================
--- trunk/coregrind/m_libcproc.c (original)
+++ trunk/coregrind/m_libcproc.c Sun Aug 23 15:37:47 2015
@@ -230,14 +230,6 @@
void VG_(env_remove_valgrind_env_stuff)(HChar** envp, Bool ro_strings,
void (*free_fn) (void *) )
{
-
-#if defined(VGO_darwin)
-
- // Environment cleanup is also handled during parent launch
- // in vg_preloaded.c:vg_cleanup_env().
-
-#endif
-
Int i;
HChar* ld_preload_str = NULL;
HChar* ld_library_path_str = NULL;
Modified: trunk/docs/internals/Darwin-notes.txt
==============================================================================
--- trunk/docs/internals/Darwin-notes.txt (original)
+++ trunk/docs/internals/Darwin-notes.txt Sun Aug 23 15:37:47 2015
@@ -69,13 +69,6 @@
- PRE(sys_posix_spawn) completely ignores signal issues, and
also ignores the file_actions argument
-* env var handling w/ exec on Darwin: is there something odd? Compare
- "valgrind env" on Darwin and Linux. On the former there are
- settings VALGRIND_LIB and VALGRIND_LIB_INNER, but not for the
- former.
- There's a suspicious-looking "#if defined(VGO_darwin)" in
- VG_(env_remove_valgrind_env_stuff). Maybe related?
-
* Cleanups: sort wrappers in syswrap-darwin.c and priv_syswrap-darwin.h
alphabetically. Also, some aren't properly implemented -- check and
print warnings
|