|
From: <sv...@va...> - 2015-08-17 15:18:09
|
Author: mjw
Date: Mon Aug 17 16:18:02 2015
New Revision: 15561
Log:
Add bug338606 testfile to none/tests/scripts/Makefile.am EXTRA_DIST.
Modified:
trunk/none/tests/scripts/Makefile.am
Modified: trunk/none/tests/scripts/Makefile.am
==============================================================================
--- trunk/none/tests/scripts/Makefile.am (original)
+++ trunk/none/tests/scripts/Makefile.am Mon Aug 17 16:18:02 2015
@@ -9,7 +9,7 @@
EXTRA_DIST = \
say-hello.helper \
bug231357.vgtest bug231357.stderr.exp bug231357.stdout.exp \
- bug338606.vgtest bug338606.stderr.exp \
+ bug338606 bug338606.vgtest bug338606.stderr.exp \
shell shell.vgtest shell.stderr.exp shell.stderr.exp-dash \
shell.stdout.exp shell.stderr.exp-dash2 shell.stderr.exp-illumos \
shell.stderr.exp-solaris shell.stderr.exp-solaris-spawn \
|
|
From: Florian K. <fl...@ei...> - 2015-08-17 17:46:59
|
My bad. Thanks for the fix. I've come to rely on make post-regtest-checks to find ommission of files in Makefile.am In this case there was no complaining about bug338606 being missing. Hmm I wonder whether the script could be beefed up a bit. Perhaps along those lines: Let L be the list of files in a directory. Let I be the list of files matching the patterns in svn:ignore. Then L-I is the list of files that should be shipped (included in the tarball). Where "should be shipped" means (in this case) to be in the list of files for EXTRA_DIST or dist_noinst_SCRIPTS. I'm copying Bart who wrote the script some time ago for any insight as to whether this might be workable. Florian On 17.08.2015 17:18, sv...@va... wrote: > Author: mjw > Date: Mon Aug 17 16:18:02 2015 > New Revision: 15561 > > Log: > Add bug338606 testfile to none/tests/scripts/Makefile.am EXTRA_DIST. > > Modified: > trunk/none/tests/scripts/Makefile.am > > Modified: trunk/none/tests/scripts/Makefile.am > ============================================================================== > --- trunk/none/tests/scripts/Makefile.am (original) > +++ trunk/none/tests/scripts/Makefile.am Mon Aug 17 16:18:02 2015 > @@ -9,7 +9,7 @@ > EXTRA_DIST = \ > say-hello.helper \ > bug231357.vgtest bug231357.stderr.exp bug231357.stdout.exp \ > - bug338606.vgtest bug338606.stderr.exp \ > + bug338606 bug338606.vgtest bug338606.stderr.exp \ > shell shell.vgtest shell.stderr.exp shell.stderr.exp-dash \ > shell.stdout.exp shell.stderr.exp-dash2 shell.stderr.exp-illumos \ > shell.stderr.exp-solaris shell.stderr.exp-solaris-spawn \ > > > ------------------------------------------------------------------------------ > _______________________________________________ > Valgrind-developers mailing list > Val...@li... > https://lists.sourceforge.net/lists/listinfo/valgrind-developers > |
|
From: Mark W. <mj...@re...> - 2015-08-17 17:56:28
|
On Mon, 2015-08-17 at 19:46 +0200, Florian Krohm wrote: > My bad. Thanks for the fix. I've come to rely on > make post-regtest-checks to find ommission of files in Makefile.am > In this case there was no complaining about bug338606 being missing. > > Hmm I wonder whether the script could be beefed up a bit. Perhaps along > those lines: > Let L be the list of files in a directory. > Let I be the list of files matching the patterns in svn:ignore. > > Then L-I is the list of files that should be shipped (included in the > tarball). Where "should be shipped" means (in this case) to be in the > list of files for EXTRA_DIST or dist_noinst_SCRIPTS. I must admit I didn't do anything fancy like that. I just did a make dist and then used that dist to build/test. Then I saw that test fail because of the missing file. Cheers, Mark |