|
From: Rich C. <rc...@wi...> - 2015-08-12 03:01:23
|
This looks like it is opensuse specific, but gcc-5 -dumpversion returns
a single digit (5) for gcc 5.1.1.
$ gcc-5 --version
gcc-5 (SUSE Linux) 5.1.1 20150713 [gcc-5-branch revision 225736]
$ gcc-5 -dumpversion
5
This patch adds support for a single digit version for gcc.
I found a reference to this problem here
https://github.com/joyent/node/pull/25671
I've reverted the 'default' gcc to gcc-4.8, as there doesn't seem to be
a way to override the gcc version in the nightly conf file (nor do I think
there should be at the moment).
Rich
diff --git a/configure.ac b/configure.ac
index d5111f7..c24b857 100644
--- a/configure.ac
+++ b/configure.ac
@@ -160,7 +160,7 @@ case "${is_clang}-${gcc_version}" in
icc-1[[3-9]].*)
AC_MSG_RESULT([ok (ICC version ${gcc_version})])
;;
- notclang-[[3-9]].*|notclang-[[1-9][0-9]]*)
+ notclang-[[3-9]].*|notclang-[[1-9][0-9]]*|notclang-[[5-9]])
AC_MSG_RESULT([ok (${gcc_version})])
;;
clang-2.9|clang-[[3-9]].*|clang-[[1-9][0-9]]*)
--
Rich Coe rc...@wi...
|
|
From: Tom H. <to...@co...> - 2015-08-12 06:11:10
|
On 12/08/15 04:01, Rich Coe wrote: > This looks like it is opensuse specific, but gcc-5 -dumpversion returns > a single digit (5) for gcc 5.1.1. > > $ gcc-5 --version > gcc-5 (SUSE Linux) 5.1.1 20150713 [gcc-5-branch revision 225736] > > $ gcc-5 -dumpversion > 5 Shouldn't you be betting opensuse to fix this? It doesn't do that on Fedora: bericote [~] % gcc -dumpversion 5.1.1 Sounds like it is just a bug in the opensuse build... Tom -- Tom Hughes (to...@co...) http://compton.nu/ |
|
From: Rich C. <rc...@wi...> - 2015-08-12 11:52:43
|
On Wed, 12 Aug 2015 07:10:57 +0100 Tom Hughes <to...@co...> wrote: > On 12/08/15 04:01, Rich Coe wrote: > > > This looks like it is opensuse specific, but gcc-5 -dumpversion returns > > a single digit (5) for gcc 5.1.1. > > > > $ gcc-5 --version > > gcc-5 (SUSE Linux) 5.1.1 20150713 [gcc-5-branch revision 225736] > > > > $ gcc-5 -dumpversion > > 5 > > Shouldn't you be betting opensuse to fix this? It doesn't do that on Fedora: > > bericote [~] % gcc -dumpversion > 5.1.1 > > Sounds like it is just a bug in the opensuse build... Sounds good to me. I wasn't sure it was distribution change or a gcc change. I wrote BZ#941428 https://bugzilla.novell.com/show_bug.cgi?id=941428 to track it. Rich -- Rich Coe rc...@wi... |
|
From: Rich C. <rc...@wi...> - 2015-08-13 16:15:05
|
On Wed, 12 Aug 2015 06:52:33 -0500 Rich Coe <rc...@wi...> wrote: > On Wed, 12 Aug 2015 07:10:57 +0100 > Tom Hughes <to...@co...> wrote: > > On 12/08/15 04:01, Rich Coe wrote: > > > > > This looks like it is opensuse specific, but gcc-5 -dumpversion returns > > > a single digit (5) for gcc 5.1.1. > > > > Shouldn't you be betting opensuse to fix this? It doesn't do that on Fedora: > > > I wrote BZ#941428 https://bugzilla.novell.com/show_bug.cgi?id=941428 to track it. BZ closed wontfix. Thoughts? --- Comment #4 from Michael Matz <ma...@su...> --- Yes, this works as designed, and indeed -dumpversion can be (and is) used for path composition. If you compare filelists and -dumpversion output of different gcc compilers you'll see that paths in opensuse packages use the version differentiator as returned by -dumpversion, _not_ as in the output of --version, this is the same on debian (and I think fedora). It's just that some packagers included the microversion in it and we don't. With the version scheme change of GCC 5 the microversion went away, basically shifting all number positions one up, so now we don't include the minor version anymore in directory paths, and hence also not in -dumpversion, so in the future it'll only be a single number. Read http://gcc.gnu.org/develop.html#num_scheme for a little background on the changed versioning scheme. Yes, this upstream change causes some hassle in packages trying to parse the version, that's unfortunate but was to be expected. -- Rich Coe rc...@wi... |
|
From: Tom H. <to...@co...> - 2015-08-13 16:22:24
|
On 13/08/15 17:14, Rich Coe wrote: > On Wed, 12 Aug 2015 06:52:33 -0500 > Rich Coe <rc...@wi...> wrote: >> On Wed, 12 Aug 2015 07:10:57 +0100 >> Tom Hughes <to...@co...> wrote: >>> On 12/08/15 04:01, Rich Coe wrote: >>> >>>> This looks like it is opensuse specific, but gcc-5 -dumpversion returns >>>> a single digit (5) for gcc 5.1.1. >>> >>> Shouldn't you be betting opensuse to fix this? It doesn't do that on Fedora: >>> >> I wrote BZ#941428 https://bugzilla.novell.com/show_bug.cgi?id=941428 to track it. > > BZ closed wontfix. > Thoughts? I can well believe it is changing given forward given the change in the gcc numbering scheme. I'm just surprised that 5.1.1 should give different results on different platforms. I wonder which one is patching it? In any case it sounds like we will need to support this going forward. Tom -- Tom Hughes (to...@co...) http://compton.nu/ |