|
From: <sv...@va...> - 2015-06-05 16:03:44
|
Author: florian
Date: Fri Jun 5 17:03:31 2015
New Revision: 15318
Log:
Remove configury bits for -Wno-empty-body. It is not needed.
Modified:
trunk/configure.ac
trunk/drd/tests/Makefile.am
Modified: trunk/configure.ac
==============================================================================
--- trunk/configure.ac (original)
+++ trunk/configure.ac Fri Jun 5 17:03:31 2015
@@ -1749,7 +1749,6 @@
CFLAGS=$safe_CFLAGS
])
-AC_GCC_WARNING_SUBST_NO([empty-body], [FLAG_W_NO_EMPTY_BODY])
AC_GCC_WARNING_SUBST_NO([format-zero-length], [FLAG_W_NO_FORMAT_ZERO_LENGTH])
AC_GCC_WARNING_SUBST_NO([nonnull], [FLAG_W_NO_NONNULL])
AC_GCC_WARNING_SUBST_NO([overflow], [FLAG_W_NO_OVERFLOW])
Modified: trunk/drd/tests/Makefile.am
==============================================================================
--- trunk/drd/tests/Makefile.am (original)
+++ trunk/drd/tests/Makefile.am Fri Jun 5 17:03:31 2015
@@ -442,8 +442,6 @@
monitor_example_SOURCES = monitor_example.cpp
new_delete_SOURCES = new_delete.cpp
-pth_cleanup_handler_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_EMPTY_BODY@
-
tsan_unittest_SOURCES = tsan_unittest.cpp
tsan_unittest_CXXFLAGS = $(AM_CXXFLAGS) \
-DTHREAD_WRAPPERS='"tsan_thread_wrappers_pthread.h"'
|
|
From: Bart V. A. <bva...@ac...> - 2015-06-05 16:10:04
|
Hello Florian, Why is it that you think that the test for -Wno-empty-body is not needed ? Older gcc compilers do not support that flag, hence the configure test for -Wno-empty-body. Bart. On 06/05/2015 09:03 AM, sv...@va... wrote: > Author: florian > Date: Fri Jun 5 17:03:31 2015 > New Revision: 15318 > > Log: > Remove configury bits for -Wno-empty-body. It is not needed. > > Modified: > trunk/configure.ac > trunk/drd/tests/Makefile.am > > Modified: trunk/configure.ac > ============================================================================== > --- trunk/configure.ac (original) > +++ trunk/configure.ac Fri Jun 5 17:03:31 2015 > @@ -1749,7 +1749,6 @@ > CFLAGS=$safe_CFLAGS > ]) > > -AC_GCC_WARNING_SUBST_NO([empty-body], [FLAG_W_NO_EMPTY_BODY]) > AC_GCC_WARNING_SUBST_NO([format-zero-length], [FLAG_W_NO_FORMAT_ZERO_LENGTH]) > AC_GCC_WARNING_SUBST_NO([nonnull], [FLAG_W_NO_NONNULL]) > AC_GCC_WARNING_SUBST_NO([overflow], [FLAG_W_NO_OVERFLOW]) > > Modified: trunk/drd/tests/Makefile.am > ============================================================================== > --- trunk/drd/tests/Makefile.am (original) > +++ trunk/drd/tests/Makefile.am Fri Jun 5 17:03:31 2015 > @@ -442,8 +442,6 @@ > monitor_example_SOURCES = monitor_example.cpp > new_delete_SOURCES = new_delete.cpp > > -pth_cleanup_handler_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_EMPTY_BODY@ > - > tsan_unittest_SOURCES = tsan_unittest.cpp > tsan_unittest_CXXFLAGS = $(AM_CXXFLAGS) \ > -DTHREAD_WRAPPERS='"tsan_thread_wrappers_pthread.h"' > > > ------------------------------------------------------------------------------ > _______________________________________________ > Valgrind-developers mailing list > Val...@li... > https://lists.sourceforge.net/lists/listinfo/valgrind-developers |
|
From: Florian K. <fl...@ei...> - 2015-06-05 18:17:19
|
Hi Bart, true, older GCCs don't support that flag. But the idea here is, that we do not want to use that flag at all. Source grepping revealed that pth_cleanup_handler.c was the only file being compiled with that option. And looking at that test I did not spot any empty bodies in conditionals. So.... -Wno-empty-body isn't needed to get a clean build. And as we're not passing that flag on the command line anymore older compilers won't be complaining. Florian On 05.06.2015 18:09, Bart Van Assche wrote: > Hello Florian, > > Why is it that you think that the test for -Wno-empty-body is not needed > ? Older gcc compilers do not support that flag, hence the configure test > for -Wno-empty-body. > > Bart. > > On 06/05/2015 09:03 AM, sv...@va... wrote: >> Author: florian >> Date: Fri Jun 5 17:03:31 2015 >> New Revision: 15318 >> >> Log: >> Remove configury bits for -Wno-empty-body. It is not needed. >> >> Modified: >> trunk/configure.ac >> trunk/drd/tests/Makefile.am >> >> Modified: trunk/configure.ac >> ============================================================================== >> >> --- trunk/configure.ac (original) >> +++ trunk/configure.ac Fri Jun 5 17:03:31 2015 >> @@ -1749,7 +1749,6 @@ >> CFLAGS=$safe_CFLAGS >> ]) >> -AC_GCC_WARNING_SUBST_NO([empty-body], [FLAG_W_NO_EMPTY_BODY]) >> AC_GCC_WARNING_SUBST_NO([format-zero-length], >> [FLAG_W_NO_FORMAT_ZERO_LENGTH]) >> AC_GCC_WARNING_SUBST_NO([nonnull], [FLAG_W_NO_NONNULL]) >> AC_GCC_WARNING_SUBST_NO([overflow], [FLAG_W_NO_OVERFLOW]) >> >> Modified: trunk/drd/tests/Makefile.am >> ============================================================================== >> >> --- trunk/drd/tests/Makefile.am (original) >> +++ trunk/drd/tests/Makefile.am Fri Jun 5 17:03:31 2015 >> @@ -442,8 +442,6 @@ >> monitor_example_SOURCES = monitor_example.cpp >> new_delete_SOURCES = new_delete.cpp >> -pth_cleanup_handler_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_EMPTY_BODY@ >> - >> tsan_unittest_SOURCES = tsan_unittest.cpp >> tsan_unittest_CXXFLAGS = $(AM_CXXFLAGS) \ >> -DTHREAD_WRAPPERS='"tsan_thread_wrappers_pthread.h"' >> >> >> ------------------------------------------------------------------------------ >> >> _______________________________________________ >> Valgrind-developers mailing list >> Val...@li... >> https://lists.sourceforge.net/lists/listinfo/valgrind-developers > > |