|
From: <sv...@va...> - 2015-04-22 13:50:20
|
Author: florian
Date: Wed Apr 22 14:50:13 2015
New Revision: 15131
Log:
Fix a silly bug.
Modified:
trunk/coregrind/m_aspacemgr/aspacemgr-linux.c
Modified: trunk/coregrind/m_aspacemgr/aspacemgr-linux.c
==============================================================================
--- trunk/coregrind/m_aspacemgr/aspacemgr-linux.c (original)
+++ trunk/coregrind/m_aspacemgr/aspacemgr-linux.c Wed Apr 22 14:50:13 2015
@@ -1314,7 +1314,7 @@
/* If the abutting segment towards lower addresses is an SkResvn
segment, then ADDR is a stack pointer into mapped memory. */
const NSegment *next = VG_(am_next_nsegment)(seg, /*forward*/ False);
- if (next == NULL || next->kind != SkResvn || seg->smode != SmUpper)
+ if (next == NULL || next->kind != SkResvn || next->smode != SmUpper)
return True;
/* OK; looks like a stack segment */
|
|
From: Julian S. <js...@ac...> - 2015-04-22 14:07:34
|
On 22/04/15 15:50, sv...@va... wrote: > Author: florian > - if (next == NULL || next->kind != SkResvn || seg->smode != SmUpper) > + if (next == NULL || next->kind != SkResvn || next->smode != SmUpper) What's the severity of this? Is it a regression or was it always there? How did you find it? J |
|
From: Florian K. <fl...@ei...> - 2015-04-22 14:20:40
|
On 22.04.2015 15:58, Julian Seward wrote: > > On 22/04/15 15:50, sv...@va... wrote: >> Author: florian >> - if (next == NULL || next->kind != SkResvn || seg->smode != SmUpper) >> + if (next == NULL || next->kind != SkResvn || next->smode != SmUpper) > > What's the severity of this? Is it a regression or was it always there? The error was in code that I had added at some point - perhaps a month ago. Not a regression. > How did you find it? I spotted it and it did not make any sense. The fix was obvious. Florian |