|
From: <sv...@va...> - 2013-03-03 17:52:39
|
philippe 2013-03-03 17:52:31 +0000 (Sun, 03 Mar 2013)
New Revision: 13306
Log:
Better document an ignored return value.
The call to VG_(gdbserver_report_signal) is ignored
in synth_fault_common (m_signals.c) as these signals
are always to be delivered (as explained by the following
comment).
=> better document that the return value is ignored on purpose.
(spotted by Florian, using Coverity)
Modified files:
trunk/coregrind/m_signals.c
Modified: trunk/coregrind/m_signals.c (+3 -2)
===================================================================
--- trunk/coregrind/m_signals.c 2013-03-03 13:23:58 +00:00 (rev 13305)
+++ trunk/coregrind/m_signals.c 2013-03-03 17:52:31 +00:00 (rev 13306)
@@ -1853,8 +1853,9 @@
info.si_code = si_code;
info.VKI_SIGINFO_si_addr = (void*)addr;
- /* even if gdbserver indicates to ignore the signal, we will deliver it */
- VG_(gdbserver_report_signal) (VKI_SIGSEGV, tid);
+ /* Even if gdbserver indicates to ignore the signal, we must deliver it.
+ So ignore the return value of VG_(gdbserver_report_signal). */
+ (void) VG_(gdbserver_report_signal) (VKI_SIGSEGV, tid);
/* If they're trying to block the signal, force it to be delivered */
if (VG_(sigismember)(&VG_(threads)[tid].sig_mask, VKI_SIGSEGV))
|