|
From: Florian K. <br...@ac...> - 2012-12-20 15:07:37
|
Hello Julian,
I noticed that libvex_ir.h is referring to IRCmpD64Result (result of
decimal floating point comparison) in comments but that type is not
defined. It should be.
The patch below fixes that. It's trivial with no functional change.
Just wanted to run it by you before I apply it.
I cannot remember whether we ever discussed using a different
encoding for IRCmpDResult. We could do that -- perhaps picking an
encoding that is less effort to encode / decode. But it's not much
of an issue. So I'm not doing this here.
Florian
Index: VEX/pub/libvex_ir.h
===================================================================
--- VEX/pub/libvex_ir.h (revision 2597)
+++ VEX/pub/libvex_ir.h (working copy)
@@ -1070,7 +1070,7 @@
* D64 x D64 -> IRCmpD64Result(I32) */
Iop_CmpD64,
- /* D128 x D128 -> IRCmpD64Result(I32) */
+ /* D128 x D128 -> IRCmpD128Result(I32) */
Iop_CmpD128,
/* QUANTIZE AND ROUND INSTRUCTIONS
@@ -1522,7 +1522,7 @@
}
IRRoundingModeDFP;
-/* Floating point comparison result values, as created by Iop_CmpF64.
+/* Binary floating point comparison result values.
This is also derived from what IA32 does. */
typedef
enum {
@@ -1531,11 +1531,17 @@
Ircr_GT = 0x00,
Ircr_EQ = 0x40
}
- IRCmpF64Result;
+ IRCmpFResult;
-typedef IRCmpF64Result IRCmpF32Result;
-typedef IRCmpF64Result IRCmpF128Result;
+typedef IRCmpFResult IRCmpF32Result;
+typedef IRCmpFResult IRCmpF64Result;
+typedef IRCmpFResult IRCmpF128Result;
+/* Decimal floating point result values. */
+typedef IRCmpFResult IRCmpDResult;
+typedef IRCmpDResult IRCmpD64Result;
+typedef IRCmpDResult IRCmpD128Result;
+
/* ------------------ Expressions ------------------ */
typedef struct _IRQop IRQop; /* forward declaration */
|
|
From: Julian S. <js...@ac...> - 2012-12-20 22:27:37
|
Florian,
That looks fine to me -- pls commit. I do vaguely remember some
discussion about this earlier this year, but none of the details.
J
On Thursday, December 20, 2012, Florian Krohm wrote:
> Hello Julian,
>
> I noticed that libvex_ir.h is referring to IRCmpD64Result (result of
> decimal floating point comparison) in comments but that type is not
> defined. It should be.
> The patch below fixes that. It's trivial with no functional change.
> Just wanted to run it by you before I apply it.
>
> I cannot remember whether we ever discussed using a different
> encoding for IRCmpDResult. We could do that -- perhaps picking an
> encoding that is less effort to encode / decode. But it's not much
> of an issue. So I'm not doing this here.
>
> Florian
>
>
> Index: VEX/pub/libvex_ir.h
> ===================================================================
> --- VEX/pub/libvex_ir.h (revision 2597)
> +++ VEX/pub/libvex_ir.h (working copy)
> @@ -1070,7 +1070,7 @@
> * D64 x D64 -> IRCmpD64Result(I32) */
> Iop_CmpD64,
>
> - /* D128 x D128 -> IRCmpD64Result(I32) */
> + /* D128 x D128 -> IRCmpD128Result(I32) */
> Iop_CmpD128,
>
> /* QUANTIZE AND ROUND INSTRUCTIONS
> @@ -1522,7 +1522,7 @@
> }
> IRRoundingModeDFP;
>
> -/* Floating point comparison result values, as created by Iop_CmpF64.
> +/* Binary floating point comparison result values.
> This is also derived from what IA32 does. */
> typedef
> enum {
> @@ -1531,11 +1531,17 @@
> Ircr_GT = 0x00,
> Ircr_EQ = 0x40
> }
> - IRCmpF64Result;
> + IRCmpFResult;
>
> -typedef IRCmpF64Result IRCmpF32Result;
> -typedef IRCmpF64Result IRCmpF128Result;
> +typedef IRCmpFResult IRCmpF32Result;
> +typedef IRCmpFResult IRCmpF64Result;
> +typedef IRCmpFResult IRCmpF128Result;
>
> +/* Decimal floating point result values. */
> +typedef IRCmpFResult IRCmpDResult;
> +typedef IRCmpDResult IRCmpD64Result;
> +typedef IRCmpDResult IRCmpD128Result;
> +
> /* ------------------ Expressions ------------------ */
>
> typedef struct _IRQop IRQop; /* forward declaration */
>
> ---------------------------------------------------------------------------
> --- LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
> Remotely access PCs and mobile devices and provide instant support Improve
> your efficiency, and focus on delivering more value-add services Discover
> what IT Professionals Know. Rescue delivers
> http://p.sf.net/sfu/logmein_12329d2d
> _______________________________________________
> Valgrind-developers mailing list
> Val...@li...
> https://lists.sourceforge.net/lists/listinfo/valgrind-developers
|